Added reply by tweet feature #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohhhhhh wow :-)
…On Wed, Aug 1, 2018, 5:13 PM Naman Gupta ***@***.***> wrote:
Make sure these boxes are checked before your pull request (PR) is ready
to be reviewed and merged. Thanks!
Closes #2671 <#2671>
- tests pass -- look for a green checkbox ✔️ a few minutes after
opening your PR -- or run tests locally with rake test
- code is in uniquely-named feature branch and has no merge conflicts
- PR is descriptively titled
- PR body includes fixes #0000-style reference to original issue #
- ask @publiclab/reviewers for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help,
and *don't be discouraged* if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at
https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday
and Friday, and publishing changes on Fridays.
Thanks!
------------------------------
You can view, comment on, or merge this pull request online at:
#3175
Commit Summary
- Added reply by tweet feature
File Changes
- *M* app/models/comment.rb
<https://github.com/publiclab/plots2/pull/3175/files#diff-0> (70)
- *A* config/initializers/twitter_client.rb
<https://github.com/publiclab/plots2/pull/3175/files#diff-1> (7)
- *M* config/schedule.rb
<https://github.com/publiclab/plots2/pull/3175/files#diff-2> (15)
- *A* db/migrate/20180801125000_add_tweet_column_to_comment.rb
<https://github.com/publiclab/plots2/pull/3175/files#diff-3> (5)
- *M* db/schema.rb.example
<https://github.com/publiclab/plots2/pull/3175/files#diff-4> (4)
Patch Links:
- https://github.com/publiclab/plots2/pull/3175.patch
- https://github.com/publiclab/plots2/pull/3175.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3175>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-5kM0XOCrbHlYu_Wb_759NX2opUks5uMhnagaJpZM4VrQGw>
.
|
|
@jywarren This is done now. |
40cd6ca to
06e56ab
Compare
|
Wow!!! Is it possible to display a link back to the tweet, from the comment? Also, in this initial implementation, whose tweets are copied back in? Just people who've linked twitter with their accounts? Very exciting 🎉 👍 👍 |
|
Yes i guess it is possible to display a link back to the tweet from
comments will dig more into this.
And yes we are only taking the tweets from those people who have signed up
using twitter OA.
For this we are first checking in user tag for the twitter handle and with
the help of that we are finding the user with email that have signed up
using OA
…On Aug 3, 2018 04:23, "Jeffrey Warren" ***@***.***> wrote:
Wow!!!
Is it possible to display a link back to the tweet, from the comment?
Also, in this initial implementation, whose tweets are copied back in?
Just people who've linked twitter with their accounts?
Very exciting 🎉 👍 👍
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYUwL1Uig7JmyIKmUXz3LrRa4h5zdks5uM4LggaJpZM4VrQGw>
.
|
|
Ok awesome. Can you write a very brief addition to the readme (in doc/)
explaining this, and we can update that as we go? Thanks!
…On Thu, Aug 2, 2018, 8:19 PM Naman Gupta ***@***.***> wrote:
Yes i guess it is possible to display a link back to the tweet from
comments will dig more into this.
And yes we are only taking the tweets from those people who have signed up
using twitter OA.
For this we are first checking in user tag for the twitter handle and with
the help of that we are finding the user with email that have signed up
using OA
On Aug 3, 2018 04:23, "Jeffrey Warren" ***@***.***> wrote:
> Wow!!!
>
> Is it possible to display a link back to the tweet, from the comment?
>
> Also, in this initial implementation, whose tweets are copied back in?
> Just people who've linked twitter with their accounts?
>
> Very exciting 🎉 👍 👍
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <#3175 (comment)>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ATwCYUwL1Uig7JmyIKmUXz3LrRa4h5zdks5uM4LggaJpZM4VrQGw
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7-nDtjM1v3RkXSN1VOrtqLXVmahks5uM5b0gaJpZM4VrQGw>
.
|
|
What about embedding the tweet directly? |
|
What about embedding like this in every comment: |
|
And also after clicking on the twitter button in right hand side we are redirected to whole twitter thread of the post. |
|
|
|
Whoa wow amazing! |
|
huh wow! that is cool, but would the text of the reply be searchable in
PublicLab.org, then? Maybe we need to copy the text into the body also, to
ensure that.
Also is it possible to not have the original question repeated? What do you
think, to be more compact?
…On Fri, Aug 3, 2018 at 7:57 AM Liz Barry ***@***.***> wrote:
Whoa wow amazing!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-wXCoX3CnmSTOqrctElJjeA_D-6ks5uNDqegaJpZM4VrQGw>
.
|
|
I guess it will show the main question with reply. |
|
@jywarren i searched, it shows question tweet along with the reply. So do we make it normal just like shown in video for now and we can look for anything else if there is any in future? What do you say? |
|
Sure that sounds good. And let's mark where we'll have to make changes to
expand this to other users in the future? In a new issue? Thanks!!!
…On Sat, Aug 4, 2018, 1:24 PM Naman Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> i searched, it shows question
tweet along with the reply. So do we make it normal just like shown in
video for now and we can look for anything else if there is any in future?
What do you say?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_ORCDi1jEEE4qf5Ml_z2ud_4hLNks5uNdiugaJpZM4VrQGw>
.
|
|
I already have a separate branch for this. Should i also open that pr? It will be work as a reference? |
07ec7e3 to
9de882e
Compare
Generated by 🚫 Danger |
|
@jywarren I think |
jywarren
reviewed
Aug 6, 2018
| @@ -0,0 +1,7 @@ | |||
| require 'twitter' | |||
| ::Client = Twitter::REST::Client.new do |config| | |||
| config.consumer_key = ENV["TWITTER_CONSUMER_KEY"] | |||
There was a problem hiding this comment.
OK, so do we need new keys for these and where should I look for them? Does it need to be the @publiclab twitter or could it be another? Thanks, just checking!!
There was a problem hiding this comment.
It can be of any account...
jywarren
reviewed
Aug 6, 2018
doc/reply_by_tweet.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| ##Reply By Tweet | |||
There was a problem hiding this comment.
ah, sorry, very small thing - a space after the ## is technically more correct Markdown and GitHub has started requiring this i think... sorry!
There was a problem hiding this comment.
Yeah! no problem i will correct it.
jywarren
reviewed
Aug 6, 2018
app/models/comment.rb
Outdated
| end | ||
|
|
||
| def self.receive_tweet_without_using_since | ||
| tweets = Client.search("to:PublicLab").collect do |tweet| |
There was a problem hiding this comment.
Ah, so hard-coded to PublicLab account. Is there a way we could specify this in a config file or environment variable? I think an env variable may be appropriate so that this could be changed and isn't hard-coded, no?
There was a problem hiding this comment.
Yeah! I will change it.
|
OK, last checks - we have to set API keys in:
How are you feeling on the performance of this code? It checks quite often... |
|
Yes we have to set Apis key in Jenkins and test it on unstable. |
|
@jywarren Is the posting of tweet is enabled? so that we can test this out? |
|
We can test on unstable if we set up the twitter keys... i'll try to do this today! |
|
I think we do also have to specify the environment variable that we are
going to use in docker?
…On Tue, Aug 7, 2018 at 7:51 PM Jeffrey Warren ***@***.***> wrote:
We can test on unstable if we set up the twitter keys... i'll try to do
this today!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYZ5htlxZA9e_uATMwp2kOzmwWiEmks5uOaJ1gaJpZM4VrQGw>
.
|
|
Tests passed!! Ready to merge. |
|
I'm going to publish this and monitor it carefully, fingers crossed!! |
|
🥳🥳
…On Wed, 6 Mar 2019, 04:12 Jeffrey Warren ***@***.*** wrote:
I'm going to publish this and monitor it carefully, fingers crossed!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYWX52D5tvjmZm_-SdI-293WYVZiLks5vTvLNgaJpZM4VrQGw>
.
|
|
Hey Jeff! Have you tested it? Is it working fine?
…On Wed, 6 Mar 2019, 04:14 Naman Gupta ***@***.*** wrote:
🥳🥳
On Wed, 6 Mar 2019, 04:12 Jeffrey Warren ***@***.*** wrote:
> I'm going to publish this and monitor it carefully, fingers crossed!!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#3175 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ATwCYWX52D5tvjmZm_-SdI-293WYVZiLks5vTvLNgaJpZM4VrQGw>
> .
>
|
|
Something went oddly with the publication but we'll try to debug today! |
|
What went wrong can you please tell me more so that I can find what could have possibly gone wrong? |
|
I think it was unrelated - we need to optimize this query with maybe
`user.status = 1` as well: #4924
? Any help appreciated!
…On Wed, Mar 6, 2019 at 11:27 AM Naman Gupta ***@***.***> wrote:
What went wrong can you please tell me more so that I can find what could
have possibly gone wrong?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJyG5SrD5IexcUj1WQyIhLaMxGof1ks5vT-w4gaJpZM4VrQGw>
.
|
|
Sure! |
|
OK, it is live! How do we test? |
|
Oh, i replied to the tweet but hadn't added |
|
Hmm, |
jywarren
reviewed
Mar 7, 2019
| unless node.nil? | ||
| twitter_user_name = tweet.user.screen_name | ||
| tweet_email = find_email(twitter_user_name) | ||
| users = User.where(email: tweet_email) |
There was a problem hiding this comment.
Hmm, can we look up the user in any other way?
jywarren
reviewed
Mar 7, 2019
| return nil | ||
| end | ||
|
|
||
| def self.find_email(twitter_user_name) |
There was a problem hiding this comment.
Hmm, this seems like it could start to push the performance of the system. Are we finding the email address of the twitter user here, and what do we use it for?
There was a problem hiding this comment.
Meaning fetching all user tags each time -- can we query any other way?
There was a problem hiding this comment.
We could narrow with:
UserTag.where.not(data: nil)But i bet we could do even better...
There was a problem hiding this comment.
UserTag.where('value LIKE (?)', 'oauth:twitter%').where.not(data: nil).count
shows 145 records currently
There was a problem hiding this comment.
Apart from this, I think we'll eventually have to figure a way to look up by twitter handle, and to do it more efficiently. The email may not even be the same one, you know?
There was a problem hiding this comment.
@namangupta01 would you mind opening a new issue for the optimization, and another to try to see if we can look up twitter users by a different system? Thank you!! And congrats on getting this merged! 🎉
There was a problem hiding this comment.
Like, maybe we need to store a new column in UserTag that is the user's twitter handle, maybe handle? It's not 100% ideal but it will make a difference for optimization as the system grows.
There was a problem hiding this comment.
And, it'll bypass the issue of the emails not matching. My email is not the same between Twitter and PL.org, actually!
|
It will be done via oauth data created via login via twitter and saved in
data field of UserTag.
…On Thu, Mar 7, 2019 at 7:24 AM Jeffrey Warren ***@***.***> wrote:
Oh, i replied to the tweet but hadn't added twitter:jywarren to my
profile; is it based on that user tag or oauth:twitter?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYcEwbfRX0vMrkDnsjMXHYgSbfT71ks5vUHFpgaJpZM4VrQGw>
.
|
|
Yes, it's correct.
…On Thu, Mar 7, 2019 at 7:27 AM Jeffrey Warren ***@***.***> wrote:
Hmm, WEBSITE_HOST_PATTERN is ://publiclab.org/n/, that should work, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYSN87-PgafXyNMJmagrEqD7NSqJvks5vUHIkgaJpZM4VrQGw>
.
|
|
Whenever a new tweet comes to our system. We find the username of that
tweet and then try to find out the same username presence in the UserTag
model and we also try to find out the email address so that we can find the
User.
…On Thu, Mar 7, 2019 at 7:31 AM Jeffrey Warren ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/models/comment.rb
<#3175 (comment)>:
> + if redirected_url != nil && redirected_url.include?(ENV["WEBSITE_HOST_PATTERN"])
+ node_id = redirected_url.split("/")[-1]
+ if !node_id.nil?
+ node = Node.where(nid: node_id.to_i)
+ if node.any?
+ return node.first
+ end
+ end
+ end
+ end
+
+ end
+ return nil
+ end
+
+ def self.find_email(twitter_user_name)
Hmm, this seems like it could start to push the performance of the system.
Are we finding the email address of the twitter user here, and what do we
use it for?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYf-1OJZl0jHJhaaMTjDaJMvPtz7zks5vUHLegaJpZM4VrQGw>
.
|
|
There are two ways using which we can do this:
1. Store the username in the separate field
2. Using UserTag.where('data LIKE (?)', nickname: username)
The first option will have more performance than the second. But it will
lead to the addition of column in either User model or UserTag model
…On Thu, Mar 7, 2019 at 7:36 AM Jeffrey Warren ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/models/comment.rb
<#3175 (comment)>:
> + if redirected_url != nil && redirected_url.include?(ENV["WEBSITE_HOST_PATTERN"])
+ node_id = redirected_url.split("/")[-1]
+ if !node_id.nil?
+ node = Node.where(nid: node_id.to_i)
+ if node.any?
+ return node.first
+ end
+ end
+ end
+ end
+
+ end
+ return nil
+ end
+
+ def self.find_email(twitter_user_name)
UserTag.where('value LIKE (?)', 'oauth:twitter%').where.not(data:
nil).count
shows 145 records currently
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYe7VY8naWhcE7hI_5jviyIiTx4LGks5vUHQegaJpZM4VrQGw>
.
|
|
There is some discussion already done at #2671 (comment) about adding Twitter handler. |
|
@jywarren I have also replied here https://twitter.com/itsmenamangupta/status/1103714192555692034 but it donot seems to be working. Can you please show me logs present in cron_log.log file? |
|
Hey @jywarren, I am opening a separate issue for this. |
|
awesome.
…On Fri, Mar 8, 2019 at 3:28 PM Naman Gupta ***@***.***> wrote:
Hey @jywarren <https://github.com/jywarren>, I am opening a separate
issue for this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-qvQmYvPsLLQ3qgIxTe11H2lvTmks5vUsewgaJpZM4VrQGw>
.
|
jywarren
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Added debounce for typeahead search optimization * Update README.md (#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (#4901) * fixes for map module (#4909) * fixes for map module * yarn.lock update * updated yarn.lock (#4911) * updated yarn.lock * tweak * Remove useless variable assignment (#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (#4926) Fixes task mentioned in issue #4749 * Bump cytoscape from 3.4.2 to 3.5.0 (#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (#4851) * fix for wiki update (#4942) * fixes, extend to title suggestions * extended to atwho
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
* Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Closes #2671
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!