Remove useless variable assignment #4885

siaw23-retired · 2019-02-27T01:40:09Z

No description provided.

plotsbot · 2019-02-27T14:09:23Z

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	2 Messages
📖	@siaw23 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`.

Generated by 🚫 Danger

jywarren · 2019-02-27T19:51:24Z

Hmm, know why it's not passing? Maybe once it is we should look to @SidharthBansal to review, thanks!

siaw23-retired · 2019-02-28T13:59:14Z

I thought this was fixed:

The command "docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rails test -d"" exited with 1.
0.00s$ echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml
The command "echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml" exited with 0.
0.01s$ tail -n +2 -q ./test/reports/TEST*.xml >> output.xml
The command "tail -n +2 -q ./test/reports/TEST*.xml >> output.xml" exited with 0.
2.23s$ if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then danger --verbose; fi
Results:
Messages:
- [ ] @siaw23 Thank you for your pull request! I'm here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And **don't be discouraged if you see errors** -- we're here to help.
- [ ] This pull request doesn't link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`.
The command "if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then danger --verbose; fi" exited with 0.
Done. Your build exited with 1.

BTW it's hard to get tests running locally for me because of this

I wonder how many people have this problem. I'll pause a bit with this PR and see what I can do with the local testing and db issue. @jywarren

jywarren · 2019-02-28T22:30:49Z

ok, thank you!

…

On Thu, Feb 28, 2019 at 8:59 AM Emmanuel Hayford ***@***.***> wrote: I thought this was fixed: The command "docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rails test -d"" exited with 1. 0.00s$ echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml The command "echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml" exited with 0. 0.01s$ tail -n +2 -q ./test/reports/TEST*.xml >> output.xml The command "tail -n +2 -q ./test/reports/TEST*.xml >> output.xml" exited with 0. 2.23s$ if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then danger --verbose; fi Results: Messages: - [ ] @siaw23 Thank you for your pull request! I'm here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And **don't be discouraged if you see errors** -- we're here to help. - [ ] This pull request doesn't link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`. The command "if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then danger --verbose; fi" exited with 0. Done. Your build exited with 1. BTW it's hard to get tests running locally for me because of this <#2712> I wonder how many people have this problem. I'll pause a bit with this PR and see what I can do with the local testing and db issue. @jywarren <https://github.com/jywarren> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4885 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ58tINX3Q4YzuQ9-Rf3swxyZX26cks5vR-CygaJpZM4bTgci> .

siaw23-retired · 2019-03-03T18:06:27Z

Please review @jywarren @SidharthBansal

SidharthBansal · 2019-03-03T18:30:13Z

Code looks good. It will be great if we can test it on the unstable branch before the merge.
Thanks for increasing the readability.

jywarren

Really nice, and easy to review too :-) 👍

jywarren · 2019-03-04T21:15:41Z

I agree it'd be great to test on unstable. But it's such a small change and I read it over very carefully. Let it fall upon my head if it fails 😟 😋

SidharthBansal · 2019-03-05T03:16:33Z

It will not fail for sure as we have oauth integration tests. Travis has not failed so no need to worry. :-) Was being extra careful that is why I suggested unstable testing. Thanks

…

On Tue, Mar 5, 2019, 2:45 AM Jeffrey Warren ***@***.***> wrote: I agree it'd be great to test on unstable. But it's such a small change and I read it over very carefully. Let it fall upon my head if it fails 😟 😋 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4885 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ60GhbyzxDazy3N-xmUFhaIaaNYHks5vTYz_gaJpZM4bTgci> .

* Added debounce for typeahead search optimization * Update README.md (#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (#4901) * fixes for map module (#4909) * fixes for map module * yarn.lock update * updated yarn.lock (#4911) * updated yarn.lock * tweak * Remove useless variable assignment (#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (#4926) Fixes task mentioned in issue #4749 * Bump cytoscape from 3.4.2 to 3.5.0 (#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (#4851) * fix for wiki update (#4942) * fixes, extend to title suggestions * extended to atwho

* Simplify username generation * Use status module * Tiny fix * Fix indentation

* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho

* Simplify username generation * Use status module * Tiny fix * Fix indentation

* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho

siaw23-retired requested review from SidharthBansal, jywarren and a team February 27, 2019 03:35

siaw23-retired removed the request for review from a team February 28, 2019 11:28

siaw23-retired added 5 commits March 3, 2019 16:45

Simplify username generation

ee184fd

Use status module

777e14c

Merge branch 'master' into remove_var_assignment

40a1091

Tiny fix

3c573bd

Fix indentation

cba731c

siaw23-retired added the ready label Mar 3, 2019

jywarren approved these changes Mar 4, 2019

View reviewed changes

jywarren merged commit d19cfcf into publiclab:master Mar 4, 2019

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019

Remove useless variable assignment (publiclab#4885)

7d355b0

* Simplify username generation * Use status module * Tiny fix * Fix indentation

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019

Remove useless variable assignment (publiclab#4885)

ea6af34

* Simplify username generation * Use status module * Tiny fix * Fix indentation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove useless variable assignment #4885

Remove useless variable assignment #4885

siaw23-retired commented Feb 27, 2019

plotsbot commented Feb 27, 2019 •

edited

Loading

jywarren commented Feb 27, 2019

siaw23-retired commented Feb 28, 2019

jywarren commented Feb 28, 2019 via email

siaw23-retired commented Mar 3, 2019

SidharthBansal commented Mar 3, 2019

jywarren left a comment

jywarren commented Mar 4, 2019

SidharthBansal commented Mar 5, 2019 via email

Remove useless variable assignment #4885

Remove useless variable assignment #4885

Conversation

siaw23-retired commented Feb 27, 2019

plotsbot commented Feb 27, 2019 • edited Loading

jywarren commented Feb 27, 2019

siaw23-retired commented Feb 28, 2019

jywarren commented Feb 28, 2019 via email

siaw23-retired commented Mar 3, 2019

SidharthBansal commented Mar 3, 2019

jywarren left a comment

Choose a reason for hiding this comment

jywarren commented Mar 4, 2019

SidharthBansal commented Mar 5, 2019 via email

plotsbot commented Feb 27, 2019 •

edited

Loading