Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't search for " " (spacebar character) in navbar typeahead search #3409

Closed
avsingh999 opened this issue Sep 23, 2018 · 4 comments
Closed

Comments

@avsingh999
Copy link
Member

Please describe the problem (or idea)

In header there is search, It's searching also space which is not good.
search

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?
first char in search cann't be space

Please show us where to look

https://publiclab.org/ ...

What's your PublicLab.org username?

999_avsingh999

This can help us diagnose the issue:

Browser, version, and operating system

chrome ubuntu 16

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@avsingh999
Copy link
Member Author

@jywarren I want to work on this If it's required

@avsingh999
Copy link
Member Author

@jywarren please review about this issue

@stefannibrasil
Copy link

stefannibrasil commented Sep 24, 2018

If you are willing to help, go ahead, that would be amazing! :)

this is something that we recently implemented, so it may help take a look at this commit first

@jywarren jywarren added help wanted requires help by anyone willing to contribute JavaScript labels Sep 24, 2018
@jywarren jywarren added this to the Search improvements milestone Sep 24, 2018
@jywarren jywarren changed the title Block space char search Don't search for " " (spacebar character) in navbar typeahead search Sep 24, 2018
@ghost ghost assigned avsingh999 Dec 14, 2018
@ghost ghost added the in progress label Dec 14, 2018
@grvsachdeva grvsachdeva removed the help wanted requires help by anyone willing to contribute label Jan 26, 2019
@jywarren
Copy link
Member

jywarren commented Sep 5, 2019

I believe this is fixed due to #4904 ! Thank you!

@jywarren jywarren closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants