Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial debounced typeahead with debug statements #3172

Closed
wants to merge 1 commit into from

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Aug 1, 2018

I haven't been able to get this to work; the debounced function is never sent! @ryzokuken perhaps you understand a bit better here?

https://lodash.com/docs/4.17.10#debounce

Fixes #3472

@plotsbot
Copy link
Collaborator

plotsbot commented Aug 1, 2018

2 Messages
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@grvsachdeva
Copy link
Member

hey @jywarren, closing this PR as we have added debounce in #4904. If you think, this PR can be taken forward, feel free to reopen. Thanks!

@jywarren
Copy link
Member Author

jywarren commented Mar 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants