Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sidekiq from 5.2.9 to 6.2.2 #10080

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 23, 2021

Bumps sidekiq from 5.2.9 to 6.2.2.

Changelog

Sourced from sidekiq's changelog.

6.2.2

  • Reduce retry jitter, add jitter to sidekiq_retry_in values #4957
  • Minimize scheduler load on Redis at scale #4882
  • Improve logging of delay jobs [Added debounce for typeahead search optimization #4904, BuonOno]
  • Minor CSS improvements for buttons and tables, design PRs always welcome!
  • Tweak Web UI Cache-Control header #4966
  • Rename internal API class Sidekiq::Job to Sidekiq::JobRecord #4955

6.2.1

  • Update RTT warning logic to handle transient RTT spikes #4851
  • Fix very low priority CVE on unescaped queue name #4852
  • Add note about sessions and Rails apps in API mode

6.2.0

  • Store Redis RTT and log if poor #4824
  • Add process/thread stats to Busy page #4806
  • Improve Web UI on mobile devices #4840
  • Refactor Web UI session usage #4804 Numerous people have hit "Forbidden" errors and struggled with Sidekiq's Web UI session requirement. If you have code in your initializer for Web sessions, it's quite possible it will need to be removed. Here's an overview:
Sidekiq::Web needs a valid Rack session for CSRF protection. If this is a Rails app,
make sure you mount Sidekiq::Web *inside* your routes in `config/routes.rb` so
Sidekiq can reuse the Rails session:

Rails.application.routes.draw do mount Sidekiq::Web => "/sidekiq" .... end

If this is a bare Rack app, use a session middleware before Sidekiq::Web:

first, use IRB to create a shared secret key for sessions and commit it

require 'securerandom'; File.open(".session.key", "w") {|f| f.write(SecureRandom.hex(32)) }

now, update your Rack app to include the secret with a session cookie middleware

use Rack::Session::Cookie, secret: File.read(".session.key"), same_site: true, max_age: 86400 run Sidekiq::Web

If this is a Rails app in API mode, you need to enable sessions.

https://guides.rubyonrails.org/api_app.html#using-session-middlewares </tr></table>

... (truncated)

Commits
  • 8e36432 Add optional Sidekiq::Job alias, see #4955
  • f1b24da Rename Sidekiq::Job, reserve for future use
  • 69b2aec Use TIMEOUT constant instead of hardcoded 2 second sleep (#4952)
  • d69e3c6 Bump, prepare for release
  • 13e2b56 Add private to Sidekiq Web UI Cache-Control to prevent request collapsing (#4...
  • 20f4bab Use no-store for web UI to prevent intermediate caching (#4966)
  • 3575ccb Reduce retry jitter, add jitter to sidekiq_retry_in, closes #4957
  • e8df351 Add missing Arabic translations (#4945)
  • 9a44071 Update Sidekiq.service as a user service (#4938)
  • 465c5c6 refactor stat method
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file Ruby labels Aug 23, 2021
@gitpod-io
Copy link

gitpod-io bot commented Aug 23, 2021

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #10080 (8d17504) into main (a313f10) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10080      +/-   ##
==========================================
- Coverage   82.10%   81.98%   -0.12%     
==========================================
  Files          98       98              
  Lines        5985     5985              
==========================================
- Hits         4914     4907       -7     
- Misses       1071     1078       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

@jywarren jywarren added the test-in-unstable Needs to be tested in unstable server before continuing; docs: https://bit.ly/3yGnSwM label Sep 2, 2021
@dependabot dependabot bot force-pushed the dependabot/bundler/sidekiq-6.2.2 branch from 2a43991 to e10bc0c Compare October 5, 2021 16:24
Bumps [sidekiq](https://github.com/mperham/sidekiq) from 5.2.9 to 6.2.2.
- [Release notes](https://github.com/mperham/sidekiq/releases)
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md)
- [Commits](sidekiq/sidekiq@v5.2.9...v6.2.2)

---
updated-dependencies:
- dependency-name: sidekiq
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/sidekiq-6.2.2 branch from e10bc0c to 8d17504 Compare October 19, 2021 22:43
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2021

Code Climate has analyzed commit 8d17504 and detected 0 issues on this pull request.

View more on Code Climate.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 8, 2021

Superseded by #10487.

@dependabot dependabot bot closed this Nov 8, 2021
@dependabot dependabot bot deleted the dependabot/bundler/sidekiq-6.2.2 branch November 8, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ruby test-in-unstable Needs to be tested in unstable server before continuing; docs: https://bit.ly/3yGnSwM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant