Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 1.10.0 #1898

Merged
merged 78 commits into from
Jan 23, 2019
Merged

[Release] 1.10.0 #1898

merged 78 commits into from
Jan 23, 2019

Conversation

kfunaoka
Copy link

@kfunaoka kfunaoka commented Jan 16, 2019

Status

PRODUCTION

Description

Release v1.10.0 (#1682)

Related PRs

branch PR
release/1.10.0 to develop #1901

Todos

  • Update CHANGELOGs
  • Update Package Versions
  • Fix CUDA problem (#1906)
  • Replace License in package.xml ([Release] 1.10.0 #1898 (comment))
  • Decide the direction that merge back to develop

Servando German and others added 30 commits October 25, 2018 11:40
* Added gitlab-ci.yml
[Fix] Milee urdf origin and scale
* Added code coverage report via lcov
* Removed python yaml dependency that was causing issues. Tested on kinetic/opencv3.3

* bug fix: error unpacking opencv version if not minor version
* Added functionality to run.sh in docker/generic

* Set default tag latest-kinetic

* Fix README.md
* add points_map_filter node

* add passthrough filter

* fix filter function

* apply clang-format

* add README.md
[Feature] Add Toyota Estima vehicle_info yaml
amc-nu and others added 6 commits January 8, 2019 21:48
* Fixes for new colcon script on ssd cuda based node

* Fixed to RTM and darknet launch files

* catkin_fix

* * catkin & colcon build successfully
* reverted back run to devel space (for the time being)
* Fixed compilation error
* Upgraded to CUDA 9
Copy link
Member

@amc-nu amc-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change license string to Apache in all the Autoware packages.

@kfunaoka
Copy link
Author

Wow. Should the package.xmls outside Autoware/ros/src/sensing/drivers/ be changed?

I've also faced the following error at launching YOLO3 via autoware/autoware:1.10.0-kinetic-rc1.

CUDA Error: CUDA driver version is insufficient for CUDA runtime version

Should I update something?

  • In host PC:
$ cat /proc/driver/nvidia/version
NVRM version: NVIDIA UNIX x86_64 Kernel Module  396.54  Tue Aug 14 19:02:34 PDT 2018
GCC version:  gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)

$ /usr/local/cuda-9.2/bin/nvcc -V
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2018 NVIDIA Corporation
Built on Tue_Jun_12_23:07:04_CDT_2018
Cuda compilation tools, release 9.2, V9.2.148
  • In autoware/autoware:1.10.0-kinetic-rc1:
$ nvcc -V
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2017 NVIDIA Corporation
Built on Fri_Sep__1_21:08:03_CDT_2017
Cuda compilation tools, release 9.0, V9.0.176

@kfunaoka
Copy link
Author

kfunaoka commented Jan 17, 2019

@esteve @amc-nu @sgermanserrano How about merging the following sequence:

  1. [Release] 1.10.0 #1898 to master (this pull request)
  2. [Release] 1.10.0 merged back to develop #1901 to develop
  3. [DO NOT MERGE YET][Fix] Revert b21b663 #1902 to develop once all install targets are confirmed to work fine

Or any other suggestion?

I think #1901 is mandatory so that the CHANGELOGs are generated correctly at next release v1.10.1 or v1.11.0. If #1901 is not merged, catkin_generate_changelog can not distinguish between which commits are v1.10.0 and which commits are next release.

@amc-nu
Copy link
Member

amc-nu commented Jan 17, 2019

From @alexandrx

Regarding @amc-nu comment before, you can easily check:
for I in `find <AUTOWARE-PATH> -type f -name "package.xml"`; do grep -i "<license" -H $I; done | grep BSD | wc -l
there are 127 different packages stating <license>BSD</license>.
Change the last part grep BSD by grep -i apache and there are only 5 packages stating Apache, and from those 5 only one package says "Apache 2". There are also some "TODO" licenses, 1 "gpl" and 1 "nonstandard".
As you know, you can fix all the package.xml files with the following trivial script:
for I in `find <AUTOWARE-PATH> -type f -name "package.xml"`; do sed -i 's/<license>BSD/<license>Apache 2.0/g' $I; done
(just in case)

@kfunaoka
Copy link
Author

Before doing that, we need to distinguish which packages can be Apache2 :)

My suggestion at the issue is that drivers can not be changed to Apache2 in my understanding.

Are there any other comments?

@kfunaoka
Copy link
Author

Thanks, @amc-nu !
He gave me the list that was all implemented as Autoware project.

  • baumer
  • pointgrey
  • vectacam
  • javad_navsat
  • nmea_navsat
  • memsic
  • hexacam
  • ouster

@amc-nu
Copy link
Member

amc-nu commented Jan 18, 2019

@kfunaoka Another item for the TODO list:

  • Change license in README and LICENSE file

@kfunaoka kfunaoka merged commit 9fae6cc into master Jan 23, 2019
@kfunaoka kfunaoka deleted the release/1.10.0 branch January 23, 2019 01:53
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.