Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Milee urdf origin and scale #1687

Merged
merged 1 commit into from
Nov 6, 2018
Merged

[Fix] Milee urdf origin and scale #1687

merged 1 commit into from
Nov 6, 2018

Conversation

aohsato
Copy link

@aohsato aohsato commented Nov 5, 2018

Status

DEVELOPMENT

Description

The Milee urdf model in current develop branch has wrong parameters, so I fixed the origin and scale.

Steps to Test or Reproduce

  1. Set Autoware/ros/src/.config/model/milee.urdf to Vehicle Model path in Setup tab.
  2. Launch Vehicle Model
  3. You can see correct Milee 3D model on Rviz.

@aohsato aohsato requested a review from yn-mrse November 5, 2018 12:39
yn-mrse
yn-mrse approved these changes Nov 5, 2018
View reviewed changes
Copy link

@yn-mrse yn-mrse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I confirmed that the origin and the scale are correct.
However, I also found the model slightly distorted. The attachment positions of panels and tires are asymmetrical.
It will be necessary to deal with this as another issue.

@yn-mrse yn-mrse mentioned this pull request Mar 14, 2023
Closed
@aohsato
Copy link
Author

aohsato commented Nov 6, 2018

@yn-mrse Thanks! Just as you said, this model has a little rough shape. Let's continue to discuss details at autowarefoundation/autoware_ai#402 .

@aohsato aohsato merged commit e083805 into develop Nov 6, 2018
@aohsato aohsato deleted the feature/fix_milee_urdf branch November 6, 2018 06:17
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@aohsato
Merge pull request autowarefoundation#1687 from CPFL/feature/fix_mile…
b430195 
…e_urdf

[Fix] Milee urdf origin and scale
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yn-mrse yn-mrse yn-mrse approved these changes

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aohsato @yn-mrse @mitsudome-r