[Fix] Link error at docker build

[kfunaoka]

Status

PRODUCTION

Description

Fix Unable to build docker image for v1.10.0 RC1 autowarefoundation/autoware_ai#490

Since https://github.com/pjreddie/darknet is no longer required for building Autoware,
it is removed from the Dockerfile.

Related PRs

• release/1.10.0

Todos

• Tests

Steps to Test or Reproduce

$ cd Autoware/docker/generic
$ ./build.sh kinetic

[kfunaoka]

Can build successfully. But ./run does not shows Runtime Manager.

[esteve]

That's because the Docker image builds Autoware with colcon, which puts the output in ./install instead of ./devel

I'm ok with reverting to catkin in the Docker image, until we can ensure that all packages have an install target. Thoughts @amc-nu @sgermanserrano ?

[sgermanserrano]

@esteve yes, I think keeping it with catkin now and aiming to move Docker also to colcon in v1.11 is best. We'll move gitlab-ci also in the next iteration

[esteve]

I'll submit a PR reverting the colcon changes in Docker.

[kfunaoka]

@esteve Since many users build from source, how about deleting deprecated message in catkin_make_release, and adding some modification into colcon_release not to be used by normal users.

I'm not sure why it worked when I tested the colcon PR. There might remain files built by catkin.

[esteve]

I've submitted #1852 to use catkin in the Docker image

[amc-nu]

@kfunaoka colcon works perfectly.
I think there is no need to remove the deprecation message. It is in fact going to be removed in 1.11, and a good chance to warn users.

[kfunaoka]

@amc-nu Got it, I agree! How can we protect users who use colcon_release?

[kfunaoka]

colcon_release and run are not compatible at least now.

[amc-nu]

Currently the message is only shown for 2 seconds then it works as usual. I think there is no need to do something else.
If you’re concerned you can add a note in the release and the wiki

[kfunaoka]

Nice! Let's list the issue in Known Bug in the release note.