Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gitlab ci #1563

Merged
merged 11 commits into from
Oct 25, 2018
Merged

Feature/gitlab ci #1563

merged 11 commits into from
Oct 25, 2018

Conversation

sgermanserrano
Copy link

Status

DEVELOPMENT

Description

autowarefoundation/autoware_ai#327 Added gitlab-ci yaml file to run the same tasks as in travis. The jobs are successfully run https://gitlab.com/ServandoGS/Autoware/pipelines

@kfunaoka
Copy link

@sgermanserrano Thank you for the great contribution! Everything seems fine under the Gitlab-CI infrastructure. Would you tell me the following questions (your experience)?

  • Is it stable compared to Travis in your trials? Does network error or other error appear sometimes in your experience?
  • How long does the current tests (build & run_tests) takes? It seems there are one and half hour (1:23:18) and more than two hours (02:15:58). Does the difference between one and half hour and more than two hours seem to come from GitLab server load (or difference of test contents)? I think deep investigation is not necessary :)

@kfunaoka
Copy link

The questions above is about your experience after your following modification:

  • Within Gitlab CI I've seen that the jobs some time fail with a "Run out of virtual memory" error -> Reducing the amount of parallel jobs when running catkin_make seems to solve the issue
  • The previous point results in longer time to build -> The timeout is set to 1h by default, but it is straightforward to change it, I set it to 3h to be on the safe side but 2h should suffice

@sgermanserrano
Copy link
Author

sgermanserrano commented Oct 10, 2018

@kfunaoka See answers below:

  • Is it stable compared to Travis in your trials? Does network error or other error appear sometimes in your experience?

I have not yet experienced errors related to the network. The failed jobs were tied to bugs on the gitlab-ci files.

  • How long does the current tests (build & run_tests) takes? It seems there are one and half hour (1:23:18) and more than two hours (02:15:58). Does the difference between one and half hour and more than two hours seem to come from GitLab server load (or difference of test contents)? I think deep investigation is not necessary :)

I'm not sure how the time shown in the pipelines is calculated. If you go inside the pipelines 02:15:58 & 1:23:18, each job has taken less than 1h30min. It might be adding the time till the jobs started.

@esteve
Copy link
Contributor

esteve commented Oct 10, 2018

@kfunaoka

Within Gitlab CI I've seen that the jobs some time fail with a "Run out of virtual memory" error -> Reducing the amount of parallel jobs when running catkin_make seems to solve the issue

This can be solved by running the Gitlab runners on our own infrastructure. Gitlab's hosted runners are rather slow and with not too much memory.

@esteve esteve self-requested a review October 25, 2018 09:49
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@esteve
Copy link
Contributor

esteve commented Oct 25, 2018

I've withdrawn #1517 (which used Azure DevOps) in favor of this one. It'd be great to have this PR deployed as soon as possible, either on Gitlab's infrastructure or our own.

@sgermanserrano sgermanserrano merged commit 17441ad into autowarefoundation:develop Oct 25, 2018
@sgermanserrano sgermanserrano deleted the feature/gitlab_ci branch October 25, 2018 12:49
@maximosipov
Copy link

Is Travis CI going to be abandoned in favour of Gitlab CI? Since the current implementation of Travis CI using industrial_ci doesn't seem to support colcon / ament / ROS2 releases and cross builds?

@sgermanserrano
Copy link
Author

@maximosipov Gitlab CI is currently being used

anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants