feat: radar object fusion #1016

scepter914 · 2022-06-01T01:55:06Z

Description

Add radar_fusion_to_detected_object package.

baseline

use radar_fusion_to_detected_object

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>

codecov · 2022-06-01T02:13:05Z

Codecov Report

Merging #1016 (4e8b4bd) into main (bf88d08) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1016      +/-   ##
========================================
- Coverage   9.66%   9.62%   -0.04%     
========================================
  Files        960     963       +3     
  Lines      64349   64584     +235     
  Branches   11183   11183              
========================================
  Hits        6217    6217              
- Misses     52969   53204     +235     
  Partials    5163    5163

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`9.63% <ø> (ø)`		Carriedforward from 51fc988

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...object/include/radar_fusion_to_detected_object.hpp	`0.00% <0.00%> (ø)`
...ted_object/src/radar_fusion_to_detected_object.cpp	`0.00% <0.00%> (ø)`
...de/radar_object_fusion_to_detected_object_node.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf88d08...4e8b4bd. Read the comment docs.

Signed-off-by: scepter914 <scepter914@gmail.com>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 7c50d2f586d6a3480ec8c62b19d81f42de403d28. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Port map based prediction (autowarefoundation#95) * Port to ROS2 Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Add missing pkg to fix build error Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Updated function Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Fix launch Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * [map_based_detection] fix launch file (autowarefoundation#115) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Convert calls of Duration to Duration::from_seconds where appropriate (autowarefoundation#131) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * fixing trasient_local in ROS2 packages (autowarefoundation#160) * [map_based_prediction] add remapping option for the launch file in map_based_prediction (autowarefoundation#199) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Enable lints in map_based_prediction (autowarefoundation#153) * port naive_path_prediction from ROS1 to ROS2 (autowarefoundation#106) * port naive_path_prediction from ROS1 to ROS2 edited CMakeLists.txt, package.xml, launch file node.cpp & node.hpp files. * review requested changes made in naive_path_prediction porting Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Ros2 v0.8.0 map based prediction (autowarefoundation#299) * restore file name for v0.8.0 update Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * fix typos in perception (autowarefoundation#862) * Revert "restore file name for v0.8.0 update" This reverts commit 47ab860adfd6664193b741c61f976eee86c5267a. * restore the return type of a function Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * delete commented out line Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Ros2 v0.8.0 naive path prediction (autowarefoundation#305) * restore naive_path_prediction files for v0.8.0 update * fix topic name (autowarefoundation#1016) * Revert "restore naive_path_prediction files for v0.8.0 update" This reverts commit 77a87c3dce4a3134d2cd11180b635748f9b0202a. Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> * update target branch for ci (autowarefoundation#309) * update target branch for ci Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [as]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [latlon_muxer]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [map_based_prediction]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [raw_vehicle_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [remote_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [turn_signal_decider]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix duration (autowarefoundation#445) * fix duration Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * change to from_seconds Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * fix other duration Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * replace -1 with 0 Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * apply ament_lint_common Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * uncrustify Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * add space Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * add another space Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Fix typo in perception module (autowarefoundation#440) * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix rolling build errors (autowarefoundation#1225) * Add missing include files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace rclcpp::Duration Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use reference for exceptions Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use from_seconds Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Perception components (autowarefoundation#1368) * [bev_optical_flow]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [object_merger]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [object_range_splitter]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [shape_estimation]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [map_based_prediction]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [naive_path_prediction]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [roi_image_saver]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [lidar_apollo_instance_segmentation]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [object_flow_fusion]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [traffic_light_map_based_detector]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [dynamic_object_visualization]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * fix some typos (autowarefoundation#1941) * fix some typos * fix typo * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Invoke code formatter at pre-commit (autowarefoundation#1935) * Run ament_uncrustify at pre-commit * Reformat existing files * Fix copyright and cpplint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * [map_based_prediction] add readme with reference (autowarefoundation#2041) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * fix angle of prediction path (autowarefoundation#2012) * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Auto/map based prediction (autowarefoundation#584) * port map_based_prediction * input tracked object * add convert function to predicted object * validate orientation availability * add trailer class * add document map based prediction (autowarefoundation#620) * port map_based_prediction * input tracked object * add convert function to predicted object * validate orientation availability * add trailer class * addd README * delete depracated perception pkg (autowarefoundation#645) * delete depracated pkg * delete object_flow_fusion and bev_optical_flow * consider upper size of path (autowarefoundation#654) * consider upper size of path * misc * fic bug * Sync .auto branch with the latest branch in internal repository (autowarefoundation#691) * add trajectory point offset in rviz plugin (autowarefoundation#2270) * sync rc rc/v0.23.0 (autowarefoundation#2258) * fix interpolation for insert point (autowarefoundation#2228) * fix interpolation for insert point * to prev interpolation pkg * Revert "to prev interpolation pkg" This reverts commit 9eb145b5d36e297186015fb17c267ccd5b3c21ef. Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> * fix topic name (autowarefoundation#2266) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Add namespace to diag for dual_return_filter (autowarefoundation#2269) * Add a function to make 'geometry_msgs::msg::TransformStamped' (autowarefoundation#2250) * Add a function to make 'geometry_msgs::msg::TransformStamped' * Add 'child_frame_id' as an argument of 'pose2transform' * Simplify marker scale initialization (autowarefoundation#2286) * Fix/crosswalk polygon (autowarefoundation#2279) * extend crosswalk polygon * improve readability * fix polygon shape * Add warning when decel distance calculation fails (autowarefoundation#2289) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * [motion_velocity_smoother] ignore debug print (autowarefoundation#2292) * cosmetic change Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * cahnge severity from WARN to DEBUG for debug info Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use util for stop_watch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix map based prediction (autowarefoundation#2200) * fix map based prediction * fix format * change map based prediction * fix spells * fix spells in comments * fix for cpplint * fix some problems * fix format and code for clang-tidy * fix space for cpplint * Update Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md * fix vector access method * fix readme format * add parameter * Update perception/object_recognition/prediction/map_based_prediction/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update perception/object_recognition/prediction/map_based_prediction/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update perception/object_recognition/prediction/map_based_prediction/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update Readme.md * Update perception/object_recognition/prediction/map_based_prediction/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * remove failure condition for 0 velocity trajectory (autowarefoundation#2295) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [mpc_follower] remove stop distance condition from stopState decision (autowarefoundation#1916) * [mpc_follower] remove stop distance condition from stopState decision Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add invalid index handling Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Move the debug marker initialization part to another file (autowarefoundation#2288) * Move the debug marker initialization part to 'debug.cpp' * Make 'isLocalOptimalSolutionOscillation' independent from 'NDTScanMatcher' (autowarefoundation#2300) * Remove an unused function 'getTransform' (autowarefoundation#2301) * Simplify iteration of initial poses (autowarefoundation#2310) * Make a transform object const (autowarefoundation#2311) * Represent poses in 'std::vector' instead of 'geometry_msgs::msg::PoseArray' (autowarefoundation#2312) * Feature/no stopping area (autowarefoundation#2163) * add no stopping area module to behavior velocity planner * apply utils * add polygon interpolation module order stopline around area is considered * devide jpass udge with stop line polygon * update docs * rename file name * update to latest * minor change for marker * update license Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * update license Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * update license Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * update license Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * minor fix * add parameter tuning at experiment * update readme * format doc * apply comments * add exception gurd * cosmetic change * fix ament * fix typo and remove for statement * & to " " * better ns * return pass judge param * add missing stoppable condition * add clear pass judge and stoppable flag * add comment * precommit fix * cpplint Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * sync rc rc/v0.23.0 (autowarefoundation#2281) * Fix side shift planner (autowarefoundation#2171) (autowarefoundation#2172) * add print debug Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * remove forward shift points when adding new point Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * remove debug print Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * format Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * Fix remove threshold Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix/pull out and pull over (autowarefoundation#2175) * delete unnecessary check * fix condition of starting pull out * Add emergency status API (autowarefoundation#2174) (autowarefoundation#2182) * Fix/mpc reset prev result (autowarefoundation#2185) (autowarefoundation#2195) * reset prev result * clean code * reset only raw_steer_cmd * Update control/mpc_follower/src/mpc_follower_core.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [hotfix] 1 path point exception after resampling (autowarefoundation#2204) * fix 1 path point exception after resampling Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * [hotfix] Fix lane ids (autowarefoundation#2211) * Fix lane ids * Prevent acceleration on avoidance (autowarefoundation#2214) * prevent acceleration on avoidance Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * fix param name Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * parametrize avoidance acc Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * change param name Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix qos in roi cluster fusion (autowarefoundation#2218) * fix confidence (autowarefoundation#2220) * too high confidence (autowarefoundation#2229) * Fix/obstacle stop 0.23.0 (autowarefoundation#2232) * fix unexpected slow down in sharp curves (autowarefoundation#2181) * Fix/insert implementation (autowarefoundation#2186) Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> * [hotfix] Remove exception in avoidance module (autowarefoundation#2233) * Remove exception * Fix clock * Remove blank line * Update traffic light state if ref stop point is ahead of previous one (autowarefoundation#2197) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix interpolation for insert point (autowarefoundation#2228) * fix interpolation for insert point * to prev interpolation pkg * fix index (autowarefoundation#2265) * turn signal calculation (#2280) * add turn signal funtion in path shifter * add ros parameters Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com> * [behavior_path_planner] fix sudden path change around ego (autowarefoundation#2305) (autowarefoundation#2318) * fix return-from-ego shift point generation logic Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * change param for trimSimilarGradShiftPoint Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add comment for issue Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update comment Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace code with function (logic has not changed) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * move func to cpp Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add comment for issue Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Add functions to make stamped scalar messages (autowarefoundation#2317) * Fix/object yaw in intersection module (autowarefoundation#2294) * fix object orientation * fix function name * add guard (autowarefoundation#2321) * reduce cost (double to float) (autowarefoundation#2298) * Add detail collision check (autowarefoundation#2274) * Add detail collision check Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Remove unused function Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix arc length Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Seperate time margin Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix parameter name Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update Readme Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Address review: Add comment for TimeDistanceArray Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Run pre-commit Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix cpplint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add return for empty polygon Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * update CenterPoint (autowarefoundation#2222) * update to model trained by mmdet3d * add vizualizer (debug) * for multi-frame inputs * chagne config * use autoware_utils::pi * project specific model and param * rename vfe -> encoder * rename general to common * update download link * update * fix * rename model_name * change training toolbox link * chage lint package * fix test error * commit suggestion * Feature/lane change detection (autowarefoundation#2331) * add old information deleter * fix access bug * change to deque * update obstacle buffer * fix some bugs * add lane change detector * make a update lanelet function * fix code style * parameterize essential values * Update perception/object_recognition/prediction/map_based_prediction/src/map_based_prediction_ros.cpp Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix slash position * remove unnecessary lines * fix format * fix format * change to new enum * fix format * fix typo and add guard * change funciton name * add lane change description Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Add Planning Evaluator (autowarefoundation#2293) * Add prototype planning evaluator Produced data for dist between points, curvature, and relative angle * Cleanup the code to make adding metrics easier * Add remaining basic metrics (length, duration, vel, accel, jerk) * Add motion_evaluator to evaluate the actual ego motion + code cleanup * Add deviation metrics * Add naive stability metric * Handle invalid stat (TODO: fix the output file formatting) * Add parameter file and cleanup * Add basic obstacle metric (TTC not yet implemented) and fix output file format * Add basic time to collision * Add lateral-distance based stability metric * Add check (at init time) that metrics' maps are complete * Publish metrics as ParamaterDeclaration msg (for openscenario) * Use lookahead and start from ego_pose when calculating stability metrics * Code cleanup * Fix lint * Add tests * Fix bug with Frechet dist and the last traj point * Finish implementing tests * Fix lint * Code cleanup * Update README.md * Remove unused metric * Change msg type of published metrics to DiagnosticArray * fix format to fix pre-commit check Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix yaml format to fix pre-commit check Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix yaml format Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * apply clang-format Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * apply clang-format Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update planning/planning_diagnostics/planning_evaluator/include/planning_evaluator/planning_evaluator_node.hpp * Update planning/planning_diagnostics/planning_evaluator/test/test_planning_evaluator_node.cpp * Update planning/planning_diagnostics/planning_evaluator/test/test_planning_evaluator_node.cpp * change lint format to autoware_lint_common Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Add keep braking function at driving state (autowarefoundation#2346) * Add keep braking function at driving state Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Remove debug messages Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Fix format Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Change diag_updater's pediod from default to 0.1sec (autowarefoundation#2348) * add cross judgement and common signal function (autowarefoundation#2319) * merge branch turn_signal_common * add turn signal function in signal decider * add cross judge in path_utilities and delete from turn_signal_decider * remove original signal calculation in lane change * omit substitution * replace turn signal decider in pull over function * modify cross judge logic * replace turn signal decider in avoidance * add readme of turn signal * update * delete print debug * update * delete lane change decider in path shifter * delete blank line * fix indent * fix typo * fix typo * decrease nest * run pre commit * Add 0 limit at forward jerk velocity filter (autowarefoundation#2340) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * add time offset param to point cloud concatenation (autowarefoundation#2303) * add offset param * clang-format Co-authored-by: Akihito OHSATO <aohsato@gmail.com> * Feature/add doc for keep braking function at driving state (autowarefoundation#2366) * Add the description of brake keeping Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Add the english document Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Improve description Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Add english description Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Fix include files (autowarefoundation#2339) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix behavior intersection module * fix behavior no stopping area module * fix planning_evaluator * fix motion_velocity_smoother * rename variable * Revert "[mpc_follower] remove stop distance condition from stopState decision (autowarefoundation#1916)" This reverts commit ff4f0b5a844d1f835f1b93bd3b36a76747b0cd02. * Revert "Add keep braking function at driving state (autowarefoundation#2346)" This reverts commit f0478187db4c28bf6092c198723dcc5ec11a9c70. * Revert "Feature/add doc for keep braking function at driving state (autowarefoundation#2366)" This reverts commit 66de2f3924a479049fce2d5c5c6b579cacbd3e49. * Fix orientation availability in centerpoint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix test_trajectory.cpp * add target link libraries * Use .auto msg in test code for planniing evaluator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix include Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com> Co-authored-by: s-murakami-esol <81723883+s-murakami-esol@users.noreply.github.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Co-authored-by: Shinnosuke Hirakawa <8327162+0x126@users.noreply.github.com> Co-authored-by: Akihito OHSATO <aohsato@gmail.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * substitute time_step for object-path (autowarefoundation#720) * fix: fix title of README.md * Apply suggestions from code review * Feature/update map based prediction readme (autowarefoundation#762) * remove unused arg * remove unsed arg * update readme * remove unused arg Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: s-murakami-esol <81723883+s-murakami-esol@users.noreply.github.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Co-authored-by: Shinnosuke Hirakawa <8327162+0x126@users.noreply.github.com> Co-authored-by: Akihito OHSATO <aohsato@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>

…utoware.universe into feature/radar_object_fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

…r914/autoware.universe into feature/radar_object_fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito · 2022-06-23T01:54:46Z

It is better to use README template. other sample : https://github.com/autowarefoundation/autoware.universe/tree/main/perception/object_merger

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 · 2022-06-23T02:44:19Z

@yukkysaito
Fixed README for template format.

yukkysaito · 2022-06-23T09:16:11Z

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp

+private:
+  rclcpp::Logger logger_;
+  Param param_{};
+  std::vector<RadarInput> filterRadarWithinObject(


maybe occurred large copy. it is better to be smart ptr

Agreed. You additionally might use move semantics.

@yukkysaito
I fixed code to use smart ptr.
Does this fix match your intention? Could you confirm?

@scepter914 Thank you!
I commented here 👍

amc-nu · 2022-06-27T13:00:51Z

.../radar_object_fusion_to_detected_object_node/radar_object_fusion_to_detected_object_node.cpp

+void RadarObjectFusionToDetectedObjectNode::onDetectedObjects(
+  const DetectedObjects::ConstSharedPtr msg)
+{
+  detected_objects_ = msg;


Is there any reason not to use message_filters?

I'll make new PR for message sync option.

Can you describe the TODO in this PR?

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp

perception/radar_fusion_to_detected_object/package.xml

.../radar_object_fusion_to_detected_object_node/radar_object_fusion_to_detected_object_node.cpp

perception/radar_fusion_to_detected_object/README.md

amc-nu · 2022-06-27T13:38:29Z

perception/radar_fusion_to_detected_object/README.md

+
+| Name                     | Type   | Description                                                                                            | Default value |
+| :----------------------- | :----- | :----------------------------------------------------------------------------------------------------- | :------------ |
+| bounding_box_margin      | double | The margin distance from bird's-eye view to choose radar pointcloud/objects within 3D bounding box [m] | 2.0           |


The distance to extend the 2D BEV Bounding Box on each side. This distance is used as a threshold to find radar centroids falling inside the extended box.

Can you please write the commit where you fixed it?

Here
scepter914@c8a936c

perception/radar_fusion_to_detected_object/README.md

amc-nu · 2022-06-27T13:41:12Z

perception/radar_fusion_to_detected_object/README.md

+
+### Weight parameters for velocity estimation
+
+| Name                                 | Type   | Description                                                                                                                                                                             | Default value |


I think these values require more explanation. The description is ambiguous.

Can you please write the commit where you fixed it?

perception/radar_fusion_to_detected_object/README.md

amc-nu · 2022-06-27T13:44:12Z

perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_1.drawio.svg

+                                        <br/>
+                                        or
+                                        <br/>
+                                        Centor gravity of radar object


Do you mean "center of gravity" or "centroid"?
I think centroid is more appropriate.

Can you please write the commit where you fixed it?

Signed-off-by: scepter914 <scepter914@gmail.com>

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp

Signed-off-by: scepter914 <scepter914@gmail.com>

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito

LGTM
pls get approval by @amc-nu

Signed-off-by: scepter914 <scepter914@gmail.com>

amc-nu

Next time please arrange properly the fixes in commits.

scepter914 · 2022-06-30T11:00:34Z

TODO

add messeage sync option
add transform option

* add radar_fusion_to_detected_object Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * fix namespace for cpplint Signed-off-by: scepter914 <scepter914@gmail.com> * fix compile error on autoware cmake Signed-off-by: scepter914 <scepter914@gmail.com> * suppress warning Signed-off-by: scepter914 <scepter914@gmail.com> * fix add twist condition Signed-off-by: yutaka <purewater0901@gmail.com> * ci(pre-commit): autofix * fix format Signed-off-by: yutaka <purewater0901@gmail.com> * add include path Signed-off-by: scepter914 <scepter914@gmail.com> * fix for CTest Signed-off-by: scepter914 <scepter914@gmail.com> * delete paramter copy Signed-off-by: scepter914 <scepter914@gmail.com> * update README Signed-off-by: scepter914 <scepter914@gmail.com> * update README Signed-off-by: scepter914 <scepter914@gmail.com> * fix to smart ptr Signed-off-by: scepter914 <scepter914@gmail.com> * exchange between smart_ptr and std::vector Signed-off-by: scepter914 <scepter914@gmail.com> * fix unused function Signed-off-by: scepter914 <scepter914@gmail.com> * add comment Signed-off-by: scepter914 <scepter914@gmail.com> * ci(pre-commit): autofix Co-authored-by: yutaka <purewater0901@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

scepter914 added 3 commits June 1, 2022 10:46

add radar_fusion_to_detected_object

259a39a

Signed-off-by: scepter914 <scepter914@gmail.com>

apply pre-commit

c5a22ee

Signed-off-by: scepter914 <scepter914@gmail.com>

fix namespace for cpplint

46c47df

Signed-off-by: scepter914 <scepter914@gmail.com>

fix compile error on autoware cmake

b62e0d0

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 requested review from yukkysaito, aohsato and miursh June 2, 2022 04:19

suppress warning

f502f21

Signed-off-by: scepter914 <scepter914@gmail.com>

yukke42 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 2, 2022

purewater0901 and others added 7 commits June 10, 2022 10:39

fix add twist condition

2e2c743

Signed-off-by: yutaka <purewater0901@gmail.com>

ci(pre-commit): autofix

5873224

fix format

3f84c2a

Signed-off-by: yutaka <purewater0901@gmail.com>

Merge branch 'feature/radar_object_fusion' of github.com:scepter914/a…

513ed24

…utoware.universe into feature/radar_object_fusion

add include path

d746edd

Signed-off-by: scepter914 <scepter914@gmail.com>

Merge branch 'feature/radar_object_fusion' of ssh://github.com/scepte…

d15734a

…r914/autoware.universe into feature/radar_object_fusion

fix for CTest

2739112

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 marked this pull request as ready for review June 20, 2022 06:37

delete paramter copy

85e559d

Signed-off-by: scepter914 <scepter914@gmail.com>

aohsato requested a review from amc-nu June 20, 2022 08:41

scepter914 added 2 commits June 23, 2022 11:40

update README

9a822b6

Signed-off-by: scepter914 <scepter914@gmail.com>

update README

5ba72b1

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito reviewed Jun 23, 2022

View reviewed changes

amc-nu reviewed Jun 27, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp Outdated Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/package.xml Outdated Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

.../radar_object_fusion_to_detected_object_node/radar_object_fusion_to_detected_object_node.cpp Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/README.md Outdated Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/README.md Outdated Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/README.md Outdated Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/README.md Outdated Show resolved Hide resolved

amc-nu reviewed Jun 27, 2022

View reviewed changes

fix to smart ptr

c8a936c

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 force-pushed the feature/radar_object_fusion branch from c5215d0 to c8a936c Compare June 30, 2022 03:03

yukkysaito reviewed Jun 30, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp Outdated Show resolved Hide resolved

exchange between smart_ptr and std::vector

a3ce98c

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito reviewed Jun 30, 2022

View reviewed changes

perception/radar_fusion_to_detected_object/include/radar_fusion_to_detected_object.hpp Outdated Show resolved Hide resolved

fix unused function

51fc988

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito self-requested a review June 30, 2022 10:10

yukkysaito approved these changes Jun 30, 2022

View reviewed changes

scepter914 and others added 2 commits June 30, 2022 19:18

add comment

aaa332b

Signed-off-by: scepter914 <scepter914@gmail.com>

ci(pre-commit): autofix

4e8b4bd

amc-nu approved these changes Jun 30, 2022

View reviewed changes

scepter914 merged commit 7593c2b into autowarefoundation:main Jun 30, 2022

scepter914 deleted the feature/radar_object_fusion branch June 30, 2022 11:00

tier4-autoware-public-bot bot mentioned this pull request Jul 1, 2022

chore: sync upstream tier4/autoware.universe#68

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: radar object fusion #1016

feat: radar object fusion #1016

scepter914 commented Jun 1, 2022 •

edited

Loading

codecov bot commented Jun 1, 2022 •

edited

Loading

yukkysaito commented Jun 23, 2022

scepter914 commented Jun 23, 2022 •

edited

Loading

yukkysaito Jun 23, 2022

amc-nu Jun 27, 2022

scepter914 Jun 30, 2022 •

edited

Loading

yukkysaito Jun 30, 2022

amc-nu Jun 27, 2022

scepter914 Jun 30, 2022

yukkysaito Jun 30, 2022

amc-nu Jun 27, 2022

scepter914 Jun 30, 2022

amc-nu Jun 30, 2022

scepter914 Jun 30, 2022

amc-nu Jun 27, 2022

scepter914 Jun 30, 2022

amc-nu Jun 30, 2022

amc-nu Jun 27, 2022

scepter914 Jun 30, 2022

amc-nu Jun 30, 2022

yukkysaito left a comment

amc-nu left a comment

scepter914 commented Jun 30, 2022


		### Weight parameters for velocity estimation

		\| Name \| Type \| Description \| Default value \|

feat: radar object fusion #1016

feat: radar object fusion #1016

Conversation

scepter914 commented Jun 1, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jun 1, 2022 • edited Loading

Codecov Report

yukkysaito commented Jun 23, 2022

scepter914 commented Jun 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scepter914 Jun 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yukkysaito left a comment

Choose a reason for hiding this comment

amc-nu left a comment

Choose a reason for hiding this comment

scepter914 commented Jun 30, 2022

scepter914 commented Jun 1, 2022 •

edited

Loading

codecov bot commented Jun 1, 2022 •

edited

Loading

scepter914 commented Jun 23, 2022 •

edited

Loading

scepter914 Jun 30, 2022 •

edited

Loading