Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): interface version 1.0.0 #2319

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Nov 18, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Release the default adapi v1.0.0.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi requested a review from a team as a code owner November 18, 2022 05:41
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 10.51% // Head: 10.51% // No change to project coverage 👍

Coverage data is based on head (070dc05) compared to base (96ae842).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2319   +/-   ##
=======================================
  Coverage   10.51%   10.51%           
=======================================
  Files        1249     1249           
  Lines       90732    90732           
  Branches    20780    20780           
=======================================
  Hits         9537     9537           
  Misses      71075    71075           
  Partials    10120    10120           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.48% <100.00%> (ø) Carriedforward from 96ae842

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/interface.cpp 62.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi self-assigned this Nov 18, 2022
@isamu-takagi isamu-takagi marked this pull request as draft November 18, 2022 08:51
@isamu-takagi isamu-takagi marked this pull request as ready for review November 24, 2022 05:12
@isamu-takagi isamu-takagi merged commit 660c6ac into autowarefoundation:main Nov 24, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/v1.0.0 branch November 24, 2022 05:12
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants