-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(intersection): fixed (stop) point insertion #2214
fix(intersection): fixed (stop) point insertion #2214
Conversation
ab18c40
to
5c20d45
Compare
Codecov ReportBase: 11.17% // Head: 11.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
==========================================
- Coverage 11.17% 11.16% -0.02%
==========================================
Files 1199 1194 -5
Lines 85831 79747 -6084
Branches 20789 20508 -281
==========================================
- Hits 9593 8900 -693
+ Misses 66112 61052 -5060
+ Partials 10126 9795 -331
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
0b7247e
to
deaaef3
Compare
) (#174) * fix(intersection): fixed (stop) point insertion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * update for lateset universe Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
) * fix(intersection): fixed (stop) point insertion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * update for lateset universe Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp
Description
Fixed stop point insertion in intersection module
Related links
https://tier4.atlassian.net/browse/T4PB-21101
Tests performed
See the ticket
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.