Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fixed (stop) point insertion #2214

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 4, 2022

Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp

Description

Fixed stop point insertion in intersection module

Related links

https://tier4.atlassian.net/browse/T4PB-21101

Tests performed

See the ticket

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin force-pushed the fix/intersection-point-insertion branch from ab18c40 to 5c20d45 Compare November 7, 2022 02:44
@soblin soblin marked this pull request as ready for review November 7, 2022 02:44
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 11.17% // Head: 11.16% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (deaaef3) compared to base (6ddcc89).
Patch coverage: 39.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
- Coverage   11.17%   11.16%   -0.02%     
==========================================
  Files        1199     1194       -5     
  Lines       85831    79747    -6084     
  Branches    20789    20508     -281     
==========================================
- Hits         9593     8900     -693     
+ Misses      66112    61052    -5060     
+ Partials    10126     9795     -331     
Flag Coverage Δ *Carryforward flag
differential 4.23% <0.00%> (?)
total 11.21% <40.47%> (+0.06%) ⬆️ Carriedforward from 4f6c3d4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rajectory_follower/pid_longitudinal_controller.hpp 0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
...ctory_follower/src/pid_longitudinal_controller.cpp 36.63% <51.51%> (-0.10%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-62.50%) ⬇️
system/default_ad_api/src/localization.cpp 0.00% <0.00%> (-37.50%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
... and 688 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin requested a review from 1222-takeshi November 7, 2022 06:03
@soblin soblin enabled auto-merge (squash) November 7, 2022 06:11
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/intersection-point-insertion branch from 0b7247e to deaaef3 Compare November 8, 2022 08:23
@soblin soblin merged commit 1321f64 into autowarefoundation:main Nov 9, 2022
@soblin soblin deleted the fix/intersection-point-insertion branch November 9, 2022 10:10
@soblin soblin restored the fix/intersection-point-insertion branch November 9, 2022 10:13
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
)

* fix(intersection): fixed (stop) point insertion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* update for lateset universe

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Nov 11, 2022
) (#174)

* fix(intersection): fixed (stop) point insertion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* update for lateset universe

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin deleted the fix/intersection-point-insertion branch November 14, 2022 06:53
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
)

* fix(intersection): fixed (stop) point insertion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* update for lateset universe

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
soblin added a commit to soblin/autoware.universe that referenced this pull request Dec 22, 2022
)

* fix(intersection): fixed (stop) point insertion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* update for lateset universe

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
)

* fix(intersection): fixed (stop) point insertion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* update for lateset universe

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants