-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ad_service_state_monitor)!: remove ad_service_state_monitor #2311
feat(ad_service_state_monitor)!: remove ad_service_state_monitor #2311
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
…ate.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…ate.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
…d-api/operation-mode
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested around the state and diagnostics, and it generally looks good to me.
One thing I'm concerned about is the sensing
diagnostics are missing.
ros2 run rqt_runtime_monitor rqt_runtime_monitor --ros-args -r /diagnostics:=/diagnostics_err
❯ ros2 topic echo /system/emergency/hazard_status --no-arr
stamp:
sec: 1669011143
nanosec: 386327711
status:
level: 3
emergency: true
emergency_holding: false
diag_no_fault: '<sequence type: diagnostic_msgs/msg/DiagnosticStatus, length: 29>'
diag_safe_fault: '<sequence type: diagnostic_msgs/msg/DiagnosticStatus, length: 0>'
diag_latent_fault: '<sequence type: diagnostic_msgs/msg/DiagnosticStatus, length: 0>'
diag_single_point_fault: '<sequence type: diagnostic_msgs/msg/DiagnosticStatus, length: 2>'
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@kenji-miyake |
This reverts commit 120d4f8.
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@kenji-miyake |
This reverts commit 46d9d4a.
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
074474f
to
52ae523
Compare
…tor (autowarefoundation#2311)" This reverts commit 8a2015f.
…tor (autowarefoundation#2311)" This reverts commit 8a2015f.
…tor (autowarefoundation#2311)" This reverts commit 8a2015f. reverting HADMapRoute to LaneletRoute Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…tor (autowarefoundation#2311)" This reverts commit 8a2015f. reverting HADMapRoute to LaneletRoute Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…owarefoundation#2311) * feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add operation mode api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: add message callback Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify topic monitoring config Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: config name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify diag name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove unused code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add autoware state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: reproduce old state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add shutdown service Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change operation mode to stop Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change operation mode to stop Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove ad_service_state_monitor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: apply removing of ad_service_state_monitor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix * fix: remove comment for sync-file Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: discard sensing topic rate status Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Revert "feat: discard sensing topic rate status" This reverts commit 120d4f8. * feat: add dummy topic rate check for alive monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Revert "feat: add dummy topic rate check for alive monitoring" This reverts commit 46d9d4a. * feat: remove sensing alive monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…owarefoundation#2311) * feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add operation mode api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: add message callback Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify topic monitoring config Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: config name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify diag name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove unused code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add autoware state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: reproduce old state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add shutdown service Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change operation mode to stop Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change operation mode to stop Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove ad_service_state_monitor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: apply removing of ad_service_state_monitor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix * fix: remove comment for sync-file Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: discard sensing topic rate status Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Revert "feat: discard sensing topic rate status" This reverts commit 120d4f8. * feat: add dummy topic rate check for alive monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Revert "feat: add dummy topic rate check for alive monitoring" This reverts commit 46d9d4a. * feat: remove sensing alive monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Description
Remove ad_service_state_monitor and add the autoware state node for compatibility. The functionality of ad_service_state_monitor has been reorganized into the autoware state node and the following packages.
/autoware/state
is now converted in autoware state node frominitialization state
,routing state
andoperation mode
provided by AD API/autoware/shutdown
service will continue to be supported in autoware state node.mission_planner
package.component_state_monitor
package./autoware/reset_route
is removed. Use/api/routing/clear_route
instead./api/routing/clear_route
.Related links
tier4/autoware_launch#568
Tests performed
Using simple_planning_simulator.
stop
when the vehicle goals.stop
when the route is cleared (while the vehicle is driving).finalizing
when/autoware/shutdown
service is called.Notes for reviewers
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.