Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(system_launch): split system_error_monitor config for simulation #577

Merged
merged 1 commit into from
Nov 25, 2022
Merged

feat(system_launch): split system_error_monitor config for simulation #577

merged 1 commit into from
Nov 25, 2022

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Nov 25, 2022

Signed-off-by: Makoto Kurihara mkuri8m@gmail.com

PR Type

  • Improvement

Related Links

Description

Add a system error monitor config file for planning simulation

/sensing/node_alive_monitoring error occurs when there is no sensing component due to the following PR.
autowarefoundation/autoware.universe#2311
It is also necessary to change diagnostic_aggregator config in the future.

Review Procedure

  • Drive on planning simulator

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@mkuri mkuri requested a review from TomohitoAndo November 25, 2022 12:11
Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this works with planning simulator.

@mkuri mkuri merged commit 98db139 into tier4:awf-latest Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants