Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_simulator_launch): fix path #2281

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 14, 2022

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Fix tier4#182

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@shmpwk
Copy link
Contributor

shmpwk commented Nov 14, 2022

@KeisukeShima Could you approve this as a code owner?

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 14, 2022
Copy link
Contributor

@KeisukeShima KeisukeShima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KeisukeShima KeisukeShima merged commit 3a6e62b into autowarefoundation:main Nov 14, 2022
@kminoda kminoda deleted the fix/tier4_simulator_launch/config_path branch November 21, 2022 04:37
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tier4_simulator_launch_param_path is conflicting a file path
3 participants