Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtc_manager_rviz_plugin): size check #2163

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Oct 27, 2022

Description

resolve #2161 size check for rtc status

image

I couldn't add as reviewer somehow so I mention here
@VRichardJP

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@VRichardJP VRichardJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 10.77% // Head: 10.77% // No change to project coverage 👍

Coverage data is based on head (90b6296) compared to base (893a3bb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2163   +/-   ##
=======================================
  Coverage   10.77%   10.77%           
=======================================
  Files        1186     1186           
  Lines       84843    84843           
  Branches    19898    19898           
=======================================
  Hits         9144     9144           
  Misses      66007    66007           
  Partials     9692     9692           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (ø) Carriedforward from 893a3bb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) October 27, 2022 08:02
@taikitanaka3 taikitanaka3 merged commit 8760b3d into main Oct 27, 2022
@taikitanaka3 taikitanaka3 deleted the fix/rtc_manager_size_check branch October 27, 2022 08:20
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rviz sometimes crash because of RTCManagerPanel plugin
3 participants