You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FYI Here's some nice-to-haves that don't need to block this PR:
When e.g. //drake/systems/framework:framework exists (as a rollup of everything in the folder), we should only list that, instead of writing out every individual component.
We should add more folder rollup libraries (possibly some of them should only be visible to this install target), so that more folders use the above simplification.
We should make the "update to a new list of exported targets" more automated, such as relocating the "here's the bazel query() you should run" code from a comment into a script that emits a .bzl file that gets load()ed here. (Writing it in python would allow us to easily capture our heuristics like the folder-rollup suggestions above, or other exceptional cases.)
A regression test could confirm that the script's output matched the checked-in version.
We should install drake/thirdParty libraries via WORKSPACE not here.
Perhaps not all of these are worth doing, but I didn't want to lose track of them.
The text was updated successfully, but these errors were encountered:
Pasted from #6452 (comment):
FYI Here's some nice-to-haves that don't need to block this PR:
//drake/systems/framework:framework
exists (as a rollup of everything in the folder), we should only list that, instead of writing out every individual component.bazel query()
you should run" code from a comment into a script that emits a.bzl
file that getsload()
ed here. (Writing it in python would allow us to easily capture our heuristics like the folder-rollup suggestions above, or other exceptional cases.)drake/thirdParty
libraries viaWORKSPACE
not here.Perhaps not all of these are worth doing, but I didn't want to lose track of them.
The text was updated successfully, but these errors were encountered: