Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to libdrake.so list of components #6464

Closed
4 tasks done
jwnimmer-tri opened this issue Jun 29, 2017 · 1 comment · Fixed by #8792
Closed
4 tasks done

Improvements to libdrake.so list of components #6464

jwnimmer-tri opened this issue Jun 29, 2017 · 1 comment · Fixed by #8792

Comments

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Jun 29, 2017

Pasted from #6452 (comment):

FYI Here's some nice-to-haves that don't need to block this PR:

  • When e.g. //drake/systems/framework:framework exists (as a rollup of everything in the folder), we should only list that, instead of writing out every individual component.
  • We should add more folder rollup libraries (possibly some of them should only be visible to this install target), so that more folders use the above simplification.
  • We should make the "update to a new list of exported targets" more automated, such as relocating the "here's the bazel query() you should run" code from a comment into a script that emits a .bzl file that gets load()ed here. (Writing it in python would allow us to easily capture our heuristics like the folder-rollup suggestions above, or other exceptional cases.)
    • A regression test could confirm that the script's output matched the checked-in version.
  • We should install drake/thirdParty libraries via WORKSPACE not here.

Perhaps not all of these are worth doing, but I didn't want to lose track of them.

@jwnimmer-tri
Copy link
Collaborator Author

I am working on this from time to time as part of #6996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants