-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer "gurobi not found" errors until build time #8578
Defer "gurobi not found" errors until build time #8578
Conversation
+@jamiesnape for feature review, please? I was going to wait to test on macOS before reviewing, but master is broken. If you're prefer to wait to review until that's fixed, that's a-ok by me too. |
This is going to make CDash very happy since we can now generate a package list in advance, I think. FYI @BetsyMcPhail. |
Reviewed 5 of 5 files at r1. tools/workspace/os.bzl, line 116 at r1 (raw file):
BTW I think I would call this tools/workspace/gurobi/repository.bzl, line 22 at r1 (raw file):
BTW The Gurobi docs use Comments from Reviewable |
147c05f
to
a5b29ec
Compare
+@soonho-tri for platform review, please. (Note that I'm going to wait for this to pass on macOS CI prior to merging.) Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion. tools/workspace/os.bzl, line 116 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Awesome. I didn't like basic_os but was stumped for a better name. Comments from Reviewable |
Reviewed 3 of 5 files at r1, 2 of 2 files at r2. Comments from Reviewable |
a5b29ec
to
46d337c
Compare
@drake-jenkins-bot mac-sierra-clang-bazel-experimental-everything please |
FYI, mac CI is not happy:
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
This is required for `bazel query` commands or `genquery()` rules to run without error. We want users without Gurobi configured to still be able to use the query features of Bazel. (This will soon become required for linters that inspect libdrake.so compositional correctness.)
46d337c
to
76b9141
Compare
@drake-jenkins-bot mac-sierra-clang-bazel-experimental-everything please
Yeah; that's the downside to having two separate BUILD files, instead of emitting them with string concatenation -- its easy to accidentally have them diverge if you're not careful. |
Reviewed 2 of 2 files at r3. Comments from Reviewable |
This is required for
bazel query
commands orgenquery()
rules to run without error. We want users without Gurobi configured to still be able to use the query features of Bazel. (This will soon become required for linters that inspectlibdrake.so
compositional correctness #6464.)Do not merge until:
-everything
CI.This change is