-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move resolve_center_of_pressure into its own file #7367
Move resolve_center_of_pressure into its own file #7367
Conversation
+@amcastro-tri for feature review, please. |
cb7db41
to
91f661e
Compare
Reviewed 10 of 10 files at r1. drake/util/drakeUtil.h, line 200 at r1 (raw file):
I think you can now also safely remove this file (and the cpp) since the two methods above are not even used anywhere. Comments from Reviewable |
drake/util/drakeUtil.h, line 200 at r1 (raw file): Previously, amcastro-tri (Alejandro Castro) wrote…
OK #7364 removes those two methods. Also note the ~180 LOC above the fold above those two methods, that is not dead yet. (The Comments from Reviewable |
91f661e
to
793cd91
Compare
Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion. drake/util/drakeUtil.h, line 200 at r1 (raw file): Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Ah, good point, I was only judging by the cpp contents. Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
+@EricCousineau-TRI for platform review per rotation, please. |
Reviewed 10 of 10 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Relates #6464, per cleaning up `util.
This change is