Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drake_cc_package_library and library_lint #8664

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Apr 24, 2018

This is a re-application of #8582, whose overview description was:

This should be substantially easier to maintain correct lists, and document for authors the purpose of the package-level library without repeating identical comments everywhere.

This is also a step along the way to #6464, where libdrake will depend on just these package-summary libraries, instead of listing out each individual component.

Now that #8667 has merged, we can rely on genquery() to work even on macOS, and thus the original commits can go back in without any additional edits.

New in this PR is the first commit, that adds some stubs for macOS support. Edit: Submitted separately as #8667. This PR is now a plain revert-of-revert.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-sierra-clang-bazel-experimental-everything please
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please

@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for sole review. I think the only review goal here is to reaffirm that this indeed is only a re-application of two commits that had been previously reviewed and merged, but then reverted.

@sammy-tri
Copy link
Contributor

:lgtm:


Review status: 0 of 41 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants