Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drake_cc_package_library for more packages #8726

Merged
merged 18 commits into from
May 1, 2018
Merged

Add drake_cc_package_library for more packages #8726

merged 18 commits into from
May 1, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented May 1, 2018 •
edited by sherm1
Loading

This now covers everything except multibody- and LCM-related packages.

Builds on #8664. Relates #6464.

This change is Reviewable

jwnimmer-tri added 17 commits May 1, 2018 08:02
@jwnimmer-tri
Add //automotive rollup library
fd675a7
@jwnimmer-tri
Add //common/proto rollup library
f04f199
@jwnimmer-tri
Add //common/trajectories rollup library
3381be0
@jwnimmer-tri
Add //controllers rollup library
68c99c2
@jwnimmer-tri
Add //geometry rollup library
60ab3f3
@jwnimmer-tri
Add //manipulation/perception rollup library
4bc077a
@jwnimmer-tri
Add //manipulation/planner rollup library
09b591c
@jwnimmer-tri
Add //manipulation/schunk_wsg rollup library
44f692d
@jwnimmer-tri
Add //manipulation/sensors rollup library
072eeb9
@jwnimmer-tri
Add //manipulation/util rollup library
1a722e6
@jwnimmer-tri
Add //math rollup library
9d81190
@jwnimmer-tri
Add //solvers rollup library
ed6806c
@jwnimmer-tri
Add //systems/controllers/plan_eval rollup library
6fa60ec
@jwnimmer-tri
Add //systems/estimators rollup library
54842ef
@jwnimmer-tri
Add //systems/rendering rollup library
c978bd0
@jwnimmer-tri
Add //systems/robotInterfaces rollup library
d35e89c
@jwnimmer-tri
Add //systems/trajectory_optimization rollup library
5424ea5
@jwnimmer-tri jwnimmer-tri force-pushed the build-libdrake-packages branch from 98c7614 to 5424ea5 Compare May 1, 2018 12:03
@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for all review, please. Note that our linters enforce that the contents of deps = [] for a drake_cc_package_library are correct, so you probably don't need to inspect the contents of that list.

@sammy-tri
Copy link
Contributor

:lgtm:

Reviewed 20 of 20 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@sammy-tri sammy-tri merged commit af78e3e into RobotLocomotion:master May 1, 2018
@jwnimmer-tri jwnimmer-tri deleted the build-libdrake-packages branch May 1, 2018 17:37
@EricCousineau-TRI EricCousineau-TRI mentioned this pull request May 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sammy-tri sammy-tri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnimmer-tri @sammy-tri