Move non-general utilities into robotInterfaces QP controllers #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@siyuanfeng-tri for feature review, please. |
f8b308f to
096edb1
Compare
It's only used from within controllers, and shouldn't be used elsewhere. We mark it private, since it's only used from .cc files, also.
It's only used from within controllers, and shouldn't be used elsewhere. We mark it private, since it's only used from .cc files, also.
096edb1 to
0db1225
Compare
|
Reviewed 25 of 25 files at r1. Comments from Reviewable |
|
+@ggould-tri for platform review per rotation, please. |
|
Reviewed 2 of 25 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #6464, in that it's difficult to make
//drake/utilwell-phrased with so much going on in there.All of the method declarations and definitions are just cut-paste of code (+ nolint tags). The using-statments, includes, and BUILD rules are fixed up by hand.
This change is