-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out subcomponents in build_components_refresh #8792
Filter out subcomponents in build_components_refresh #8792
Conversation
+@jamiesnape for feature review, please. |
Reviewed 3 of 3 files at r1. tools/install/libdrake/build_components.bzl, line 8 at r1 (raw file):
BTW -- Author's discretion as it is not part of this PR, but it seems odd to me to put "when adding new components" right after "don't update this list". Perhaps this comment is in the wrong place? tools/install/libdrake/build_components_refresh.py, line 123 at r1 (raw file):
This is going to disturb the sort you do above (line 64) , resulting in surprising sorts like the position of Perhaps it would be better to sort after this step rather than in Comments from Reviewable |
Reviewed 3 of 3 files at r1. Comments from Reviewable |
This comment dates from the very first prototype of the installation and packaging, where the top-level install list had to explicitly call out the license files for each external. However, with the install.bzl rules that we use now, where license data files are installed by the external itself, and declared and enforced in the build system, the comment here no longer makes any sense. Indeed, the target it refers to no longer exists.
e0d0727
to
4ea2362
Compare
Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions. tools/install/libdrake/build_components.bzl, line 8 at r1 (raw file): Previously, ggould-tri wrote…
Done. Wow, that comment was old and very, very stale. tools/install/libdrake/build_components_refresh.py, line 123 at r1 (raw file): Previously, ggould-tri wrote…
Done. Great point. It even fixed a bug (rigid_body_plant should have been commented as unpackaged). Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
I tested this locally; the only difference in the install is that |
Closes #6464.
Ideally we would continue to work on components still marked as
# unpackaged
in the list, but for now at least it seems worth locking in this stage before moving on to fix the stragglers.This change is