-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move drake-distro/drake up one level; rename drake-distro -> drake in all docs. #6996
Comments
++1! |
That would be so nice!! |
I'm not sure why we should rush it before a monthly release? The installed binary copy of Drake would change relatively little (I think only the resource searching would change); downstream include paths like As to the proposal itself, I would support changing e.g. |
i think of the monthly release as being both a binary release and a tag for people to build from source. i don't have a strong preference about moving it up a level or not. i thought it would be more standard to separate the src from the e.g. build/ bazel-bin/ etc with an explicit src subdirectory. |
I agree with @jwnimmer-tri that we should move everything up one level, though I think I agree with @RussTedrake that it would be nice to do so before we tag a release. (if we are doing filesystem housekeeping, I would also like the matlab under the bindings directory) |
+1 for moving it up one level. I think that if we use Potential Bike-Shedding: Also, given that the paths themselves don't involve \cc @stonier regarding the role of |
+1 for moving it up a level too and +1 before a release. I expect there will be a few changes around the installation and |
|
I am going to examine how to go about this. |
I think it would be best to delay until I have stripped the rest of the CMake, but no harm in planning. |
Right. I'm preparing patchsets that assume most or all CMakeLists.txt are gone (and so the patchsets don't touch the CMake code, and wouldn't pass CI right now), and I'll wait to PR them until other work lands first (CMake removal, Trusty removal, etc.) -- though a few tidy-ups might PR before then. |
The main rename has been merged. If you have rebase or merge trouble, the first suggestion is:
The first merge should go as usual -- any merge conflicts should be as expected with normal workflow, and resolved as normal. The second merge is just renames, so should do git magic and occur without trouble. The only remaining problems was if your feature branch contained files that were not yet on master. You will probably have to |
N.B. - the installation instructions on sphinx (http://drake.mit.edu/from_source.html) still refer to drake-distro, but should now just be drake. hoorah! |
So far it looks like we might be able to survive with the new layout. Next up, I'll remove some of the transition shims left over on master, as well as som documentation updates. |
Most code and docs are revised now, so I'm lowering the priority. There are still BUILD file cleanups pending. |
as we purge all of the externals-handling via cmake (and therefore loose the drake-distro/externals directory), I think it would be appropriate to make that change? Bazel's handling of externals feels less like a superbuild than the cmake externals version did.
If yes, it would be a big change but the time is probably now (before we post our first monthly release).
Is it worth it?
The text was updated successfully, but these errors were encountered: