Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix //drake labels names in bindings/pydrake/... #8018

Merged
merged 6 commits into from
Feb 9, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 9, 2018

Relates #6996.

I am PR'ing these changes in chunks. The plan is that once everything is converted, we'll add a deprecation warning to the 6996.bzl before finally removing it.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+(status: priority: low)
+@EricCousineau-TRI for all review, please.

@EricCousineau-TRI
Copy link
Contributor

:lgtm:, with minor question about commit granularity.


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):
BTW Is there a motivation for separating each directory into commits, versus just squashing these? There does not seem to be a functional separation between the commits.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, EricCousineau-TRI wrote…

BTW Is there a motivation for separating each directory into commits, versus just squashing these? There does not seem to be a functional separation between the commits.

I think it makes rebasing a little bit easier. If there's a conflict, you just --skip and redo that one file from scratch.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit 188eadc into RobotLocomotion:master Feb 9, 2018
@jwnimmer-tri jwnimmer-tri deleted the hoist-cleanup-pr4 branch February 9, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants