-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional WooCommerce onboarding styling to connection flow #34380
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~56 bytes removed 📉 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~4 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2221 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~2651 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
e313d11
to
39ca9b0
Compare
I added e2e labels to just do a test run now; feel free to remove them once they're done. Good to re-run them before merging once more, tho. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested that these changes work fine with Jetpack connect flow 👍
…iables for header, add note about temporary usage, fix copy, pull color-studio from npm.
BTW did I say yet that I love the new styles here and wish we could Murielize all signup flows soon! 💪 Jetpack test failures seemed unrelated (fix in #34401) Didn't look into failing wp-desktop tests. |
Thanks for the PR feedback and for looking at the Jetpack test failures! It looks like other tests are failing now pulling in the new color-studio version. I wonder if maybe something is cached on circleci? It shouldn't be pulling from GitHub now. I'll try rerunning them a bit later. |
Likely unsynced |
b99fe89
to
59ec86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing out well for me.
This PR implements the remaining missing styles for the WooCommerce/Jetpack onboarding connection flow. This includes the white header bar, width/spacing changes, link and color treatments, and the largest visual change: Muriel/Material styled form components.
It is only enabled in development, is only active through a specific connection flow, and builds upon the previously merged PRs: #32993 and #33073.
This PR implements a temporary Muriel styled
TextControl
component inclient/extensions/woocommerce/components
that matches the interface of@wordpress/components
'sTextControl
and thecalypso-ui
component proposed at #34277. This PR can be switched over to use thecalypso-ui
component, once it is unblocked by WordPress/gutenberg#16227. (The login code is loaded via SSR). This temporary component allows us to test the styles all together, and allows me to keep iterating unblocked on the WooCommerce.com styles next (which are also hosted in Calypso).Closes woocommerce/woocommerce-admin#2166. Closes woocommerce/woocommerce-admin#2152.
Screenshots
Testing instructions
npm install
to get the updatedcolor-studio
packagenpm start
--
If you have WooCommerce / WooCommerce Admin Installed:
WooCommerce Admin
and to tell it to point at local Calypso.wp-config.php
or a plugin file:define( 'WOOCOMMERCE_CALYPSO_LOCAL', true );
.POST
request to/wp-json/wc-admin/v1/onboarding/profile
on your local site, settingskipped
andcompleted
to false./wp-admin/admin.php?page=wc-admin
on your local site, and the onboarding wizard should be displayed.Get Started
, and thenActivate & Continue
.If you don't want to install WooCommerce Admin:
https://wordpress.com
withhttp://calypso.localhost:3000
and replace thefrom
parameter in the URL (it may be something likeconnection-banner
orlanding-page-bottom
) withfrom=woocommerce-setup-wizard
. See Pastebin213d5
or ping me if you have issues.Walk through the login and sign-up flows. View both views via the link in the footer. Test typing in the inputs.
Open
config/development.json
and disable thejetpack/connect/woocommerce
flag. Refresh the login and sign-up pages and verify the existing Jetpack connection flow appears.