-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WooCommerce onboarding connection track events and stop auto authorization for the new onboarding flow #34414
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~49 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~544 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~272 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
c7e486c
to
d8c08d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested out the flow with a jurassic.ninja site and can verify the tracks events were being fired 👍
…iables for header, add note about temporary usage, fix copy, pull color-studio from npm.
d8c08d7
to
b5e2455
Compare
b5e2455
to
402e64f
Compare
This PR adds some WooCommerce Onboarding connection track events to the WooCommerce onboarding connection flow (see #34414 and p6riRB-4rG-p2 forbackground). Note that these events are only fired in this context, and not during normal Jetpack onboarding.
It also adds a few additional missing styles to the connection page, and stops auth authorization from happening for the new WooCommerce flow.
See p1560449057014200-slack-wc-onboarding for background on the events.
Branched from #34380.
Testing instructions
npm run test-client
to make sure all tests pass.--
If you have WooCommerce / WooCommerce Admin Installed:
WooCommerce Admin
and to tell it to point at local Calypso.wp-config.php
or a plugin file:define( 'WOOCOMMERCE_CALYPSO_LOCAL', true );
.POST
request to/wp-json/wc-admin/v1/onboarding/profile
on your local site, settingskipped
andcompleted
to false./wp-admin/admin.php?page=wc-admin
on your local site, and the onboarding wizard should be displayed.Get Started
, and thenActivate & Continue
.If you don't want to install WooCommerce / WooCommerce Admin:
Disconnect Jetpack from your site
Click “Setup Jetpack”.
On the connection/authorization screen ( https://wordpress.com/jetpack/connect/authorize?client_id= ….. ) copy and paste the whole URL.
Replace
https://wordpress.com
withhttp://calypso.localhost:3000
and replace thefrom
parameter in the URL (it may be something likeconnection-banner
orlanding-page-bottom
) withfrom=woocommerce-setup-wizard
. See Pastebin213d5
or ping me if you have issues.Paste
localStorage.setItem( 'debug', 'calypso:analytics*' );
in your console.Test login and signup to see that events are firing.
You may run into an issue testing logged out, if your store email matches a WPCOM account. D30046-code will help with this.