Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Onboarding - Profile Wizard: Implement Muriel styling for form components #2166

Closed
4 of 5 tasks
justinshreve opened this issue May 3, 2019 · 1 comment · Fixed by Automattic/wp-calypso#34380
Closed
4 of 5 tasks
Assignees
Labels
focus: components Issues for woocommerce components focus: onboarding

Comments

@justinshreve
Copy link
Collaborator

justinshreve commented May 3, 2019

The profile wizard uses Muriel components for form inputs, buttons, etc. These components exist in Gutenberg, but we need to implement our own layer of styling over these.

See p1556119186006300-slack-wc-onboarding for Figma links containing more information on the styles.

We will need styles for:

  • Primary Button
  • Secondary Button
  • Checkboxes
  • Form Inputs
  • Dropdowns

In terms of implementation, we should be overriding these styles at the component level. See p1557235811036900-slack-nux. Newspack is also doing something similar. Example: Automattic/newspack-plugin#46.

On hold pending: #2166 (comment)

@justinshreve justinshreve added focus: components Issues for woocommerce components focus: onboarding labels May 3, 2019
@justinshreve justinshreve added this to the Onboarding - Profile Wizard milestone May 3, 2019
@justinshreve justinshreve self-assigned this May 15, 2019
@justinshreve
Copy link
Collaborator Author

As a follow-up from Slack, we plan on importing components from the Newspack team to avoid code duplication. They have already written the exact form component set we need. See p1558027644118700-slack-newspack-a8c.

In the meantime, we can just use @wordpress/components directly, because the signature/props will remain the same.

@justinshreve justinshreve added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label May 17, 2019
@justinshreve justinshreve removed their assignment May 17, 2019
@justinshreve justinshreve removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jun 18, 2019
@justinshreve justinshreve self-assigned this Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Issues for woocommerce components focus: onboarding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant