Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack E2E: remove Jumpstart #34401

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Jetpack E2E: remove Jumpstart #34401

merged 2 commits into from
Jul 4, 2019

Conversation

simison
Copy link
Member

@simison simison commented Jul 2, 2019

Changes proposed in this Pull Request

  • Remove "Jumpstart" aka "Recommended features" related tests in Jetpack E2E tests.

Jumpstart was removed in Automattic/jetpack#12747

Testing instructions

N/A

@simison simison added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Jetpack e2e Testing Runs the full suite of Jetpack e2e automated tests against this PR using calypso.live labels Jul 2, 2019
@simison simison requested review from brbrr, Stojdza and bsessions85 July 2, 2019 10:32
@simison simison requested a review from a team as a code owner July 2, 2019 10:32
@simison simison self-assigned this Jul 2, 2019
@matticbot
Copy link
Contributor

@simison simison requested a review from a team July 2, 2019 10:32
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@Stojdza Stojdza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simison These changes look good to me 👍 Affected test is passing, and failed tests don't seem related.

step( 'Is redirected back to the Jetpack dashboard with Jumpstart displayed', async function() {
return await this.wpAdminJetpack.jumpstartDisplayed();
step( 'Can then see the Jetpack plan page in Calypso', async function() {
return await PlansPage.Expect( driver );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flow would then continue with onboarding checklist and returning to WP admin, but I'd rather PR those tests separately since it's a lot more work.

@simison simison added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 4, 2019
@simison simison merged commit 395c860 into master Jul 4, 2019
@simison simison deleted the update/e2e-jetpack-jumpstart branch July 4, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack [Status] Needs Jetpack e2e Testing Runs the full suite of Jetpack e2e automated tests against this PR using calypso.live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants