Remove Jumpstart #12747

simison · 2019-06-18T22:01:54Z

Removing everything jumpstart related.

~~Basically informs me that I should first PR a change which just modifies minimum to hide Jumpstart from Jetpack, and then PR separately follow-ups to clean up the code.~~ Got convinced by @dereksmart that this is solid. (p1560894750228800-slack-jetpack-dna). If further testing reveals surprises that take more than a day to fix, we can reassess and do the simple hiding instead.

Jumpstart might normally get disabled once some module toggles are changed. (Will still need to confirm if this is the case). If so, should we keep Jumpstart for those who didn't activate any features in the checklist, @jeffgolenski?

See inline comments for some todos.

Resolves #12601

Changes proposed in this Pull Request:

Remove Jumpstart feature

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Removes existing feature.

Testing instructions:

Create a new Jetpack site and connect it
From Calypso checklist, click back to wp-admin without changing settings — you shouldn't see jumpstart and no errors, observe also PHP log.
With another site, when in Calypso, turn on some features in settings and then return to wp-admin. Still no jumpstart and no errors.
Try different plan tiers

Proposed changelog entry for your changes:

Remove feature to activate recommended features with one click

matticbot · 2019-06-18T22:02:02Z

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D29600-code before merging this PR. Thank you!

simison · 2019-06-18T22:03:10Z

.eslintignore

@@ -3,6 +3,7 @@
 /_inc/blocks
 /_inc/build
 /_inc/client/**/test/*.js
+/_inc/jetpack-modules.models.js


ES5 file that was eslint-erroring a whole lotta. :-)

composer.lock

jetpackbot · 2019-06-18T22:03:58Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 8ecdd06

simison · 2019-06-18T22:06:50Z

class.jetpack.php

-		if ( ! Jetpack_Options::get_option( 'jumpstart' ) ) {
-			Jetpack_Options::update_option( 'jumpstart', 'new_connection' );
-
-			$jetpack = Jetpack::init();


Need to investigate what was going on here and if jumpstart option is used to somehow detect the state of Jetpack, not just state of Jumpstart? Update: probably not, says Derek

simison · 2019-06-18T22:13:51Z

Need to investigate what's up with this:

jetpack/tools/build-module-headings-translations.php

Line 39 in f74b64b

'recommended description' => 'Jumpstart Description',

Update: those lines can be removed, "recommended features" is synonym of jumpstart

Update: removed lines

simison · 2019-06-18T22:18:41Z

packages/options/legacy/class.jetpack-options.php

@@ -93,7 +93,6 @@ public static function get_option_names( $type = 'compact' ) {
 			'identity_crisis_whitelist',    // (array)  An array of options, each having an array of the values whitelisted for it.


Noting that I got heaps of phpcs errors from this file and had to use --no-verify to skip tests and commit:

FILE: packages/options/legacy/class.jetpack-options.php ---------------------------------------------------------------------- FOUND 39 ERRORS AND 10 WARNINGS AFFECTING 41 LINES ---------------------------------------------------------------------- ....

simison · 2019-06-18T22:35:26Z

I'd like early testing/reviews on this even tho I'd still consider it also to be in progress.

sirreal

This seems to work fine and some quick digging around doesn't reveal any leftover jumpstart code, although I'm sure there's some 🙂

I do think we need some careful consideration:

What's enabled by default?
What would have been enabled by jumpstart?
What would be covered by the new checklist?
How does the following the checklist differ from triggering jumpstart?

I'd like to have a clear understanding of the above written out so we can refer to this PR and have clear expectations.

jeherve

❤️

This looks good to me. I'd be tempted to merge it sooner rather than later, so we can test it with all future PR reviews in the next few days.

dereksmart · 2019-06-19T16:59:48Z

This tested well for me too. Would be happy to merge after resolving conflicts.

simison · 2019-06-19T23:19:38Z

Rebased & removed lockfile changes

simison · 2019-06-19T23:42:48Z

What's enabled by default?
What would have been enabled by jumpstart?
What would be covered by the new checklist?

Here's a list of tasks in the checklist — I'm adding ✅to those that were also enabled by Jumpstart:

Downtime Monitoring ✅
Automatic Plugin Updates
WordPress.com sign in ✅
Site Accelerator ✅
Lazy Load Images ✅
Video Hosting
Enhanced Search

Things that were always auto-enabled regardless:

Brute force login attack protection
Backup and Scan
Spam filtering

matticbot · 2019-06-20T10:00:57Z

simison, Your synced wpcom patch D29600-code has been updated.

jeherve

This still looks good to me. Merging.

lezama · 2019-06-20T12:53:24Z

+16 −820 ❤️

* Remove Jumpstart * Add _inc/jetpack-modules.models.js to eslintignore * Revert lockfile change * Update build-module-headings-translations.php * Update composer.lock

simison added [Status] In Progress Jumpstart labels Jun 18, 2019

simison requested a review from a team June 18, 2019 22:01

matticbot added the Touches WP.com Files label Jun 18, 2019

simison commented Jun 18, 2019

View reviewed changes

composer.lock Outdated Show resolved Hide resolved

simison commented Jun 18, 2019

View reviewed changes

simison requested a review from a team June 18, 2019 22:09

simison changed the title ~~Remove/jumpstart~~ Remove Jumpstart Jun 18, 2019

simison commented Jun 18, 2019

View reviewed changes

simison requested a review from jeffgolenski June 18, 2019 22:21

simison added this to the 7.5 milestone Jun 18, 2019

simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels Jun 18, 2019

simison added the [Pri] High label Jun 18, 2019

sirreal previously approved these changes Jun 19, 2019

View reviewed changes

jeherve previously approved these changes Jun 19, 2019

View reviewed changes

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress [Status] Needs Review This PR is ready for review. labels Jun 19, 2019

simison added 4 commits June 20, 2019 02:04

Remove Jumpstart

88217c2

Add _inc/jetpack-modules.models.js to eslintignore

6259b07

Revert lockfile change

a12a454

Update build-module-headings-translations.php

89b2c56

simison dismissed jeherve’s stale review via 89b2c56 June 19, 2019 23:07

simison dismissed sirreal’s stale review via 89b2c56 June 19, 2019 23:07

simison force-pushed the remove/jumpstart branch from c838df2 to 89b2c56 Compare June 19, 2019 23:07

Update composer.lock

8ecdd06

jeherve approved these changes Jun 20, 2019

View reviewed changes

jeherve merged commit 9576f91 into master Jun 20, 2019

matticbot added the [Status] Needs Changelog label Jun 20, 2019

jeherve deleted the remove/jumpstart branch June 20, 2019 10:10

matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 20, 2019

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Jun 20, 2019

jeherve added a commit that referenced this pull request Jun 20, 2019

Changelog: add #12747

6c22e5d

jeherve pushed a commit that referenced this pull request Jun 27, 2019

Remove Jumpstart (#12747)

a71e4bd

* Remove Jumpstart * Add _inc/jetpack-modules.models.js to eslintignore * Revert lockfile change * Update build-module-headings-translations.php * Update composer.lock

simison mentioned this pull request Jul 2, 2019

Jetpack E2E: remove Jumpstart Automattic/wp-calypso#34401

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Jumpstart #12747

Remove Jumpstart #12747

simison commented Jun 18, 2019 •

edited

Loading

matticbot commented Jun 18, 2019

simison Jun 18, 2019

jetpackbot commented Jun 18, 2019 •

edited

Loading

simison Jun 18, 2019 •

edited

Loading

simison commented Jun 18, 2019 •

edited

Loading

simison Jun 18, 2019 •

edited

Loading

simison commented Jun 18, 2019

sirreal left a comment

jeherve left a comment

dereksmart commented Jun 19, 2019

simison commented Jun 19, 2019

simison commented Jun 19, 2019

matticbot commented Jun 20, 2019

jeherve left a comment

lezama commented Jun 20, 2019

		@@ -93,7 +93,6 @@ public static function get_option_names( $type = 'compact' ) {
		'identity_crisis_whitelist', // (array) An array of options, each having an array of the values whitelisted for it.

Remove Jumpstart #12747

Remove Jumpstart #12747

Conversation

simison commented Jun 18, 2019 • edited Loading

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

matticbot commented Jun 18, 2019

simison Jun 18, 2019

Choose a reason for hiding this comment

jetpackbot commented Jun 18, 2019 • edited Loading

simison Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

simison commented Jun 18, 2019 • edited Loading

simison Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

simison commented Jun 18, 2019

sirreal left a comment

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

dereksmart commented Jun 19, 2019

simison commented Jun 19, 2019

simison commented Jun 19, 2019

matticbot commented Jun 20, 2019

jeherve left a comment

Choose a reason for hiding this comment

lezama commented Jun 20, 2019

simison commented Jun 18, 2019 •

edited

Loading

jetpackbot commented Jun 18, 2019 •

edited

Loading

simison Jun 18, 2019 •

edited

Loading

simison commented Jun 18, 2019 •

edited

Loading

simison Jun 18, 2019 •

edited

Loading