-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display WooCommerce styles during JP Onboarding when coming from the setup wizard #32993
Display WooCommerce styles during JP Onboarding when coming from the setup wizard #32993
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~528 bytes added 📈)
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~561 bytes added 📈)
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legacy SCSS Stylesheet (~1278 bytes added 📈)
The monolithic CSS stylesheet that is downloaded on every app load. Sections (~2059 bytes added 📈)
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~7887 bytes added 📈)
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
e1bc782
to
ef77228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly glanced through the code, and it's looking well, nice work 👍
Haven't tested though, and I think this could use some thorough testing in most of the big Jetpack in addition to the mentioned Woo flows.
I'm pinging @Automattic/luna and @Automattic/jetpack-design for review and testing, as I'm no longer working on Jetpack NUX & Onboarding.
Fixed some issues in 260bfd5. Thanks! I've been making sure to run through this PR with the normal flow as well (no I've adjusted the testing directions to make sure we get some more 👀 on that as well. |
…etup wizard, and display Woo colors.
…and alias the from keyword where neccessary.
260bfd5
to
13cb8d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the flows with and without the modified from
attribute and both are working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned last week, we might be changing the background color, so no need to change that (or the text color) for now.
I messaged you on Slack re colors in general. The button bg / stroke colors were incorrect (my bad), I've updated this in Figma just now.
For the hover color, we can use Woo Purple 600 for the background.
I've addressed the color feedback over in the other PR.
…#33073) * Update co-branded Jetpack & WooCommerce header on connection and login routes * Additional design treatments to better align with the wp-admin onboarding wizard * Additional design treatments to better align with the wc-admin onboarding wizard * Handle PR Feedback: Add a CSS variable for the heading border, adjust line-height for login footer links, add isWoo prop to JetpackHeader for future potential co-branding with hosts. * Update color schemes for the latest designs * Fix color and increase thickness. Use css var instead of sass var
This PR detects when we are in the Jetpack onboarding wizard, but have entered through the WooCommerce setup wizard. This is so we can do some co-branding, and keep the connection experience consistent throughout the store setup process. See p6riRB-4rG-p2 and woocommerce/woocommerce-admin#2152.
This is step one of the process. It only adds the ability to target styles for this case, and implements the base background/button styles. It does not update the copy yet, or display the Woo logo, etc. It is also behind a feature flag so we can iterate on these differences without affecting the current flows.
@jameskoster I believe I could use some help here making sure I'm using the correct colors, hovers, accents, etc. I only had the background, text color, and button color to work with. See the mixin.
To Test:
npm run test-client
and make sure all tests pass.Jetpack > Dashboard > Connections > Site connection > Manage site connection > Disconnect
.https://wordpress.com
withhttp://calypso.localhost:3000
and replace thefrom
parameter in the URL (it may be something likeconnection-banner
orlanding-page-bottom
) withfrom=woocommerce-setup-wizard
. See Pastebin213d5
or ping me if you have issues.Screenshots: