-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add co-branded Jetpack & WooCommerce header during connection process #33073
Add co-branded Jetpack & WooCommerce header during connection process #33073
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~528 bytes added 📈)
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~561 bytes added 📈)
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legacy SCSS Stylesheet (~1278 bytes added 📈)
The monolithic CSS stylesheet that is downloaded on every app load. Sections (~2059 bytes added 📈)
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~7887 bytes added 📈)
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
260bfd5
to
13cb8d3
Compare
3685735
to
bba3e82
Compare
… line-height for login footer links, add isWoo prop to JetpackHeader for future potential co-branding with hosts.
Thank you for the great feedback! I've updated that color to a CSS variable, adjusted the line-height on those login links, and persisted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on the code structure and matching what is already there, but still testing out great in both logged-in and logged-out flows.
I think we should use the same design language across our cobranded login screens. Here's the one from Pressable: The biggest difference is the removal of the black line under the logos and the larger, brighter logos. I recommend going the same route as the Pressable cobranding by making the logos bigger and brighter. I also think the dark line (probably a bottom border) can be removed. What do you think? |
Also, I tested this, and it worked as expected. 👍 |
/cc @jameskoster for
|
This design is based on the recent Muriel sprint where we sought to align account steps across our products. It carries through to the rest of our on-boarding experience. So if this step looked / felt different to the rest, that would create unwanted friction and disruption. Based on this, if anything, I would suggest that the other co-branded screens are updated to match this one. But that deserves some discussion as we didn't definitively lock those designs down. For now, if it's not a lot of work to make this particular screen match the original designs (seems like it's already done) then I think we should stick with it to avoid the aforementioned friction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @justinshreve! Pre-approving, but one very tiny thing I noticed (both in the wc-admin onboarding and here) is that the logo in the designs has a slightly thicker "+".
I know this logo was swapped recently, so the Figma one may be irrelevant at this point and you may have more details on this.
Use css var instead of sass var
…g from the setup wizard [Feature Flagged] (#32993) * Detect when we are entering Jetpack onboarding from the WooCommerce setup wizard, and display Woo colors. * Address PR Feedback: Remove props parameter from isWoo in signup.js, and alias the from keyword where neccessary. * Add co-branded Jetpack & WooCommerce header during connection process (#33073) * Update co-branded Jetpack & WooCommerce header on connection and login routes * Additional design treatments to better align with the wp-admin onboarding wizard * Additional design treatments to better align with the wc-admin onboarding wizard * Handle PR Feedback: Add a CSS variable for the heading border, adjust line-height for login footer links, add isWoo prop to JetpackHeader for future potential co-branding with hosts. * Update color schemes for the latest designs * Fix color and increase thickness. Use css var instead of sass var
This PR builds upon the WooCommerce styles added in #32993 by updating the header to contain a co-branded WooCommerce & Jetpack logo. The header is styled per the designs at p6riRB-4rG-p2 and woocommerce/woocommerce-admin#2152. It also updates the heading and sub-heading copy.
Testing instructions
To Test:
Jetpack > Dashboard > Connections > Site connection > Manage site connection > Disconnect
.https://wordpress.com
withhttp://calypso.localhost:3000
and replace thefrom
parameter in the URL (it may be something likeconnection-banner
orlanding-page-bottom
) withfrom=woocommerce-setup-wizard
. See Pastebin213d5
or ping me if you have issues.