Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote experimental changes #476

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Promote experimental changes #476

merged 10 commits into from
Oct 15, 2024

Conversation

aaronleopold
Copy link
Collaborator

This PR updates develop with the merged features sitting in experimental. The two notable changes are:

  • Smart list features and associated fixes
    • Cool new macro for filters
  • SDK package which replaces and refactors all of the api package usage
    • The types package has also been removed, now living in sdk to better support third-party community projects/efforts using it

I'll aim to merge this in a day or so

aaronleopold and others added 9 commits September 28, 2024 14:41
@aaronleopold
♻️ Rewrite api package as standalone sdk (#457)
ad84b66 
* just messing around

* progress with new patterns

* wip more type gen

* working tirlessly before these layover flights 🥵

* library API

* add interceptor and build out new api

* continue building out sdk

* fully ported functions to classes

* start using sdk

* wip: replace api stuff with sdk

* wip: almost done with hooks!

* finish primary hooks

* wip: fix the world

* wip: fix the world

* la la laaaa la la

* its alive!

* fix scan method

* add api tests and fix existing tests

* fix lint

* try fix weird dotenv error
@aaronleopold
🚧 Restructure book clubs (#461)
af9ea58
@aaronleopold
Merge remote-tracking branch 'origin/develop' into experimental
5095fa8
@JMicheli
♻️ Add macro for generating smart filters (#465)
97859f8
@aaronleopold
✨ Smart list filter builder (#464)
5906397 
* this is awful

* tdd this thing

* more tests

* hmm

* fix generation, wip conversions

* add grouping

* starting to have something I think

* note future stuff

* wip: value renderers

* reintroduce form

* cleanup

* ITS ALIVE

* tweaks

* wip: locale for smart list form

* add locale for smart list form

* add tests, add mine param

* add missed locale

* setup settings for sidebar pattern

* fix blip to null when deleting group

* rearrange components, simplify enum variant

* wip: build out settings pages

* update smart list docs

* fix change detection, fix attribute label, fix misc sdk issues

* fix web build

* wip: add the filters which you can select in UI

* fix basic number value

* add perf disclaimer

* wip: fix numbers and dates

* lunch stuff

* fix date parsing, cleanup

* normalize date

* fix update preferences
@aaronleopold
🚚 Move generated types to sdk package (#471)
cdbcbfd 
* initial effort

* batch replace

* batch replace

* batch replace

* run codegen

* update readme

* fix horizontal card list params

* fix type error

* fix reader?

* fix reader?
@aaronleopold
Merge remote-tracking branch 'origin/develop' into experimental
fe5a043
@aaronleopold
🐛 Smartlist and misc SDK-related fixes (#474)
75c1068 
* fix basic smart list update, emailer api, server api

* try separate docker vs local prisma cache key

* remove extra joiner, oops

* fix test, run generation

* rerun codgen after merge

* fix disabled link for create list
@aaronleopold
✨ Extend smartlist filters for series metadata (#475)
5a16c99 
I've added UI hookups for filtering on series metadata, as requested on Discord
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.24459% with 281 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/src/db/entity/book_club/member.rs 0.00% 60 Missing ⚠️
apps/server/src/routers/api/mod.rs 0.00% 35 Missing ⚠️
apps/server/src/routers/api/v1/book_club.rs 0.00% 31 Missing ⚠️
core/src/db/entity/user/entity.rs 0.00% 29 Missing ⚠️
core/src/db/entity/book_club/schedule.rs 0.00% 22 Missing ⚠️
apps/server/src/filter/basic_filter.rs 5.26% 18 Missing ⚠️
apps/server/src/routers/api/v1/smart_list.rs 0.00% 16 Missing ⚠️
core/src/db/entity/book_club/discussion.rs 0.00% 14 Missing ⚠️
core/src/lib.rs 0.00% 13 Missing ⚠️
crates/smart-filter-gen/src/enum_data.rs 78.57% 12 Missing ⚠️
... and 7 more
Files with missing lines Coverage Δ
apps/server/src/routers/utoipa.rs 0.00% <ø> (ø)
core/src/db/query/pagination.rs 0.00% <ø> (ø)
crates/integrations/src/notifier/discord_client.rs 45.58% <ø> (+0.66%) ⬆️
...rates/integrations/src/notifier/telegram_client.rs 61.81% <ø> (+1.10%) ⬆️
crates/stump-config-gen/src/gen_config_impls.rs 92.94% <100.00%> (+0.04%) ⬆️
crates/stump-config-gen/src/gen_partial_config.rs 98.87% <100.00%> (+0.06%) ⬆️
crates/stump-config-gen/src/type_utils.rs 88.13% <100.00%> (ø)
apps/server/src/routers/api/v1/library.rs 0.00% <0.00%> (ø)
apps/server/src/routers/api/v1/media/individual.rs 0.00% <0.00%> (ø)
crates/stump-config-gen/src/config_vars.rs 90.69% <33.33%> (+11.53%) ⬆️
... and 14 more

@aaronleopold aaronleopold marked this pull request as ready for review October 15, 2024 02:23
@aaronleopold aaronleopold merged commit 9d35ba9 into develop Oct 15, 2024
10 checks passed
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronleopold @JMicheli