-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Smart list filter builder #464
Conversation
Codecov ReportAttention: Patch coverage is
|
I believe I've sorted all of the numeric issues. I've been thinking about it and I think I might just merge this in tonight, I'm excited to get it out and tested. It will also be a good buffer to have it in experimental for a few days, release I am certain there are multiple bugs here and there, it is still an experimental feature with rough edges and that should be expected. FYI @JMicheli, if you were planning on updating the macros and pushing to this feature branch it can just be a follow-up instead. I got things compiling with your suggestions, as well, so thank you! |
Resolves #174
I'm super excited about this one. This PR adds a proper filter builder to the UI so you can construct smart lists without having to interact with the API directly. A few other highlights besides the builder itself:
There are a lot of changes here, though, so rather than enumerating them all I think a picture is worth a thousand words:
There are a few remaining tasks before this can go to experimental, the big one being that numeric fields are 50/50 for functionality. E.g. filtering a number field by applying a range. I'm going to prioritize getting
0.0.7
out this week, so this might not land inexperimental
until the following week.