Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Rewrite api package as standalone sdk #457

Merged
merged 22 commits into from
Sep 28, 2024

Conversation

aaronleopold
Copy link
Collaborator

This may seem insignificant or unnecessary on the surface, but this PR is really important for things down the road. The two big things this paves the way for are:

The built-in web app and desktop app (WIP) will continue to use sessions, the mobile app however will now be able to swap to tokens. It's as simple as new Api(baseURL, 'tokens'). I will eventually add OPDS V2 to this new SDK, as well.

ℹ️ I want to note that while I did structure this package to be standalone, I don't have plans on publishing it to something like npm. If there winds up being an actual demand, sure I'll add some workflow to publish it. Otherwise, the effort isn't worth it if the built-in apps are the only consumers 😅

Super excited to see what this refactor allows down the road

@aaronleopold aaronleopold marked this pull request as ready for review September 28, 2024 21:38
@aaronleopold
Copy link
Collaborator Author

I'm going to merge this to experimental knowing that there is almost certainly some things which I've likely missed. I'm working on improved filtering and sorting to include relations and aggregates, and want to minimize conflicts

@aaronleopold aaronleopold merged commit ad84b66 into experimental Sep 28, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/client-api-rework branch September 28, 2024 21:41
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant