Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move generated types to sdk package #471

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Conversation

aaronleopold
Copy link
Collaborator

This chore makes the sdk package much more standalone. The generated types living in the package directly means that if I ever push this to npm it will now have the types it references, instead of pulling them from another package (@stump/types)

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/src/lib.rs 0.00% 2 Missing ⚠️
apps/server/src/routers/api/mod.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
apps/server/src/routers/api/mod.rs 0.00% <0.00%> (ø)
core/src/lib.rs 0.00% <0.00%> (ø)

@aaronleopold aaronleopold marked this pull request as ready for review October 10, 2024 03:52
@aaronleopold aaronleopold merged commit cdbcbfd into experimental Oct 10, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/move-types branch October 10, 2024 03:52
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant