Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Smartlist and misc SDK-related fixes #474

Merged
merged 7 commits into from
Oct 12, 2024

Conversation

aaronleopold
Copy link
Collaborator

This PR fixes a handful of the issues brought up by testers after the smartlist UI was merged. I will tackle a few more before merge. The list of fixes is as follows:

  • Fix issues with changing the name of the list
  • Fix issues with the root-level joiner, in particular where changing it in the form wouldn't update it
  • Fix emailer query which broke UI from invalid URL in SDK
  • Fix /version and /check-for-update URLs in SDK

I've also updated the prisma cache key in CI so local builds and docker don't clash

@aaronleopold aaronleopold marked this pull request as ready for review October 12, 2024 23:28
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
core/src/db/filter/smart_filter.rs 80.41% <ø> (ø)

@aaronleopold aaronleopold merged commit 75c1068 into experimental Oct 12, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/experimental-fixes branch October 13, 2024 00:01
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant