RT-1.30: BGP nested import/export policy attachment changes incorporated #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated metadata.textproto
vender check included for NOKIA
Added deviations.
Updated nested_policies_test.go
Updated the code as per the instructions in README.md, replacing ACCEPT_ROUTE with NEXT_STATEMENT.
Added the definitive statement for NEXT_STATEMENT.
Added deviation for prefixset_Mode.
Added deviation to skip rp match set options.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #3532 / 29e5b00Virtual Devices
Hardware Devices
|
|
/fptest virtual |
Pull Request Test Coverage Report for Build 12375857720Details
💛 - Coveralls |
|
/fptest virtual |
|
HW log with these changes are available at - b/380856696 |
|
/fptest virtual |
* Add codeowners for transceiver
* 🧹: housekeeping to ensure well-scoped CODEOWNERS.
* (M) .github/CODEOWNERS
- `s/featureprofiles-maintainers/featureprofiles-approvers/g` to
have a clear group of folks that are the default CODEOWNERS.
* Add @morrowc as a security codeowner.
* deviation for RT-2.9 * updated deviation list to use existing one * removed metadata.pb.go changes --------- Co-authored-by: Ram <rmachat@google.com>
…penconfig#3646) * Avoid adopting potentially unreleased changes in third-party action. * Fix version for all third-party actions.
…g#3614) * extra delay * use Watch.Await instead of sleep * use Watch.Await instead of sleep --------- Co-authored-by: Ram <rmachat@google.com>
…config#3372) Remove deviation bgp_conditions_match_community_set_unsupported Co-authored-by: Pramod Maurya <pramodmaurya@google.com> Co-authored-by: Darren Loher <dloher@google.com>
…g#2767) * updated RT-1.32 * resolving conflicts * Fixing go static error * Resolving conflicts * Resolving conflicts * Changed folder name as per latest git commit * updating with git copy of README * Resolving conflicts * Resolving conflicts * updated * updating deviations * resolving conflicts * Resvoling conflicts * resolving conflicts * Added verification for setmedincrease policy * updated verification * Resolving conflicts * resoving conflicts * Resolving conflicts * Resolving commit * resolving conflicts * REsolving conflicts * removed space * updated with native cli * resolving conflicts * Update deviations.go * Update deviations.go * Update deviations.go * Update metadata.pb.go * Update metadata.pb.go * Update actions_MED_LocPref_prepend_flow_control_test.go * Update metadata.textproto * Update metadata.textproto * Update deviations.go * Update metadata.proto * Update metadata.pb.go * regenerated proto stubs * REsolving conflicts * Resolving conflicts * Update internal/deviations/deviations.go Co-authored-by: Darren Loher <dloher@google.com> * updating comments * REsolving erros * updating comment * updating review comment --------- Co-authored-by: Swetha-haridasula <haridasula@google.com> Co-authored-by: Nisha Sadhasivam <nsadhasivam@google.com> Co-authored-by: Pramod Maurya <pramodmaurya@google.com> Co-authored-by: Darren Loher <dloher@google.com>
Add example of specific spiffe format
* update ACL-1.2 with controller card * add missing paths for acls and use case
* Update CODEOWNERS This may workaround the pr-approvals bug skymoore/required-approvals#22 which only recognizes approvals from group members, not individuals * add isis owner group * Mapped feature area owner group --------- Co-authored-by: Pramod Maurya <pramodmaurya@google.com>
* Update scaling test * Add separation to validate traffic splits --------- Co-authored-by: nflath <nflath@google.com> Co-authored-by: Xiao Wang <39514181+xw-g@users.noreply.github.com>
…g#3675) Co-authored-by: Darren Loher <dloher@google.com>
…nconfig#3471) * SFLOW-1: Configuring sflow collector respective to IPv4 and IPv6 Following changes are made - 1. Removing explicit_interface_in_default_vrf, considering test is using non-default VRF mvrf1 for the interface. 2. Based on discussion b/290965827, refactoring the sflow collector configurations to be part of respective V4 and V6 test. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Updating script to send 10M+ packets to have consistency with the sample generation. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Incorporating changes based on reveiw comment * Updating sflow packet count with tolerance check to 8 from 9 for consistency * Incorporating review comment * Optimizing to avoid duplicate variables
* Added check for the fabrics which are removable * Implemented empty check correctly * updated --------- Co-authored-by: hattikals <hattikals@juniper.net>
Co-authored-by: Swetha-haridasula <haridasula@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.11.0 to 5.13.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.11.0...v5.13.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixing it as per README * updating comments * restoring afisafisettofalse config * enabling v4 v6 afi-safi
…eria changes incorporated (openconfig#3574) * RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria Updated metadata.textproto -vender check included for NOKIA -Added deviations. Updated import_export_multi_test.go - Added community-set-refs configuration for add_comm 60/70. - Delete routePolicy policy applied to neighbour before configurating multipolicy. - Added deviation for prefixset_Mode. - Policy result changed to ACCEPT from NEXT-STATEMENT for policy match_community_regex statements. * fixing interface level config and timer (openconfig#3577) * Removed "skip_bgp_send_community_type" deviation * Revert "Removed "skip_bgp_send_community_type" deviation" * - Removed unwanted deviation check "SkipSetRpMatchSetOptions". --------- Co-authored-by: Ram <rmachat@google.com> Co-authored-by: trathod <tushar.rathod@nokia.com>
…3686) * Create README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: Darren Loher <dloher@google.com>
* intial code * defined deviations * updated deviation usage * taken care of comments, also changed static route replace to update to preserve base routes * added default bgp instance name in metadata file * Update internal/cfgplugins/bgp_policy.go function description change Co-authored-by: Darren Loher <dloher@google.com> * Update internal/cfgplugins/bgp_policy.go function description change 2 Co-authored-by: Darren Loher <dloher@google.com> * added bug info to the deviations --------- Co-authored-by: Darren Loher <dloher@google.com> Co-authored-by: Ram <rmachat@google.com>
* RT-7.4: Updating for deviation usage
1. Updating metadata file for missing deviations
2. Updating script to use deviation combination.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* RT-7.4: Updating for deviation usage
1. Updating metadata file for missing deviations
2. Updating script to use deviation combination.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* Update comments in proto * add changes to pb.go files * removed unused deviations --------- Co-authored-by: Pramod Maurya <pramodmaurya@google.com>
…configuration (openconfig#3660) * add deviation for ETH channal rate class non-supported. Arista device does not support this yet * bug fix for channel definition in the interface.go file * Revert "add deviation for ETH channal rate class non-supported. Arista device does not support this yet" This reverts commit b1af1fc. * Arista device is not supporting ETH channel rate class yet. Adding this deviation. * adding a new PMD typeof PMD_400GBASE_ZR_PLUS for the functional testing * adding new testbed topology for new optics PMD 400G ZR plus * Update interface.go * updated metadata.pb.go file * Arista device is not supporting ETH channel rate class yet. Adding this deviation. * adding newly introduced deviation of unsupported rate class to the tests * removing folder of tmp * removing empty file called values * add deviation for ETH channal rate class non-supported. Arista device does not support this yet * bug fix for channel definition in the interface.go file * Revert "add deviation for ETH channal rate class non-supported. Arista device does not support this yet" This reverts commit b1af1fc. * Arista device is not supporting ETH channel rate class yet. Adding this deviation. * adding a new PMD typeof PMD_400GBASE_ZR_PLUS for the functional testing * adding new testbed topology for new optics PMD 400G ZR plus * Update interface.go * updated metadata.pb.go file * fixed metadata.pb.go --------- Co-authored-by: Pramod Maurya <pramodmaurya@google.com> Co-authored-by: Yiwen Hu <163206410+yiwenhu-g@users.noreply.github.com>
* fixing collateral from PR3658 which was failing for Arista * fixing collateral from PR3658 which was failing for Arista
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated metadata.textproto
vender check included for NOKIA
Added deviations.
Updated nested_policies_test.go
Added deviation for prefixset_Mode.
Added deviation to skip rp match set options.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."