Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #3668

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Update CODEOWNERS #3668

merged 3 commits into from
Dec 26, 2024

Conversation

dplore
Copy link
Member

@dplore dplore commented Dec 21, 2024

This may workaround the pr-approvals bug skymoore/required-approvals#22 which only recognizes approvals from group members, not individuals

@OpenConfigBot
Copy link

OpenConfigBot commented Dec 21, 2024

Pull Request Functional Test Report for #3668 / 25b428c

No tests identified for validation.

Help

@dplore dplore marked this pull request as ready for review December 21, 2024 00:45
@dplore dplore requested a review from a team December 21, 2024 00:45
@coveralls
Copy link

coveralls commented Dec 21, 2024

Pull Request Test Coverage Report for Build 12501585492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12500915911: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

self-maurya
self-maurya previously approved these changes Dec 22, 2024
dplore and others added 3 commits December 26, 2024 13:51
This may workaround the pr-approvals bug skymoore/required-approvals#22 which only recognizes approvals from group members, not individuals
@self-maurya self-maurya merged commit 50a42c5 into main Dec 26, 2024
15 of 16 checks passed
@self-maurya self-maurya deleted the dplore-patch-12 branch December 26, 2024 08:52
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Jan 17, 2025
* Update CODEOWNERS

This may workaround the pr-approvals bug skymoore/required-approvals#22 which only recognizes approvals from group members, not individuals

* add isis owner group

* Mapped feature area owner group

---------

Co-authored-by: Pramod Maurya <pramodmaurya@google.com>
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
* Update CODEOWNERS

This may workaround the pr-approvals bug skymoore/required-approvals#22 which only recognizes approvals from group members, not individuals

* add isis owner group

* Mapped feature area owner group

---------

Co-authored-by: Pramod Maurya <pramodmaurya@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants