SFLOW-1: Configuring sflow collector respective to IPv4 and IPv6 #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following changes are made -
1. Removing explicit_interface_in_default_vrf, considering test is using non-default VRF mvrf1 for the interface.
2. Based on discussion b/290965827, refactoring the sflow collector configurations to be part of respective V4 and V6 test.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #3471 / 1ecf1bbVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12636405277Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
generation.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
|
/fptest virtual |
self-maurya
previously approved these changes
Dec 27, 2024
|
/fptest virtual |
self-maurya
requested changes
Jan 3, 2025
rohit-rp
previously approved these changes
Jan 3, 2025
nsadhasivam
requested changes
Jan 6, 2025
self-maurya
approved these changes
Jan 7, 2025
ampattan
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Jan 17, 2025
…nconfig#3471) * SFLOW-1: Configuring sflow collector respective to IPv4 and IPv6 Following changes are made - 1. Removing explicit_interface_in_default_vrf, considering test is using non-default VRF mvrf1 for the interface. 2. Based on discussion b/290965827, refactoring the sflow collector configurations to be part of respective V4 and V6 test. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Updating script to send 10M+ packets to have consistency with the sample generation. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Incorporating changes based on reveiw comment * Updating sflow packet count with tolerance check to 8 from 9 for consistency * Incorporating review comment * Optimizing to avoid duplicate variables
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
…nconfig#3471) * SFLOW-1: Configuring sflow collector respective to IPv4 and IPv6 Following changes are made - 1. Removing explicit_interface_in_default_vrf, considering test is using non-default VRF mvrf1 for the interface. 2. Based on discussion b/290965827, refactoring the sflow collector configurations to be part of respective V4 and V6 test. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Updating script to send 10M+ packets to have consistency with the sample generation. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Incorporating changes based on reveiw comment * Updating sflow packet count with tolerance check to 8 from 9 for consistency * Incorporating review comment * Optimizing to avoid duplicate variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made -
-
packetsToSendis updated from 1M to 10M, andppsRatefrom 100k to 300k.- Considering increase in traffic packets, now script expecting minimum 8 samples (with tolerance) instead of only 1 sample (from 1M traffic packets) earlier.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."