Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scaling test TE-14.1 #3556

Merged
merged 9 commits into from
Jan 6, 2025
Merged

Update scaling test TE-14.1 #3556

merged 9 commits into from
Jan 6, 2025

Conversation

nflath
Copy link
Contributor

@nflath nflath commented Oct 31, 2024

Updates the scaling test on TE-14.1 on current projections.

@nflath nflath requested a review from a team as a code owner October 31, 2024 20:18
@nflath nflath requested a review from xw-g October 31, 2024 20:18
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 31, 2024

Pull Request Functional Test Report for #3556 / 571adaa

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
TE-14.1: gRIBI Scaling
Cisco 8000E status
TE-14.1: gRIBI Scaling
Cisco XRd status
TE-14.1: gRIBI Scaling
Juniper ncPTX status
TE-14.1: gRIBI Scaling
Nokia SR Linux status
TE-14.1: gRIBI Scaling
Openconfig Lemming status
TE-14.1: gRIBI Scaling

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
TE-14.1: gRIBI Scaling
Cisco 8808 status
TE-14.1: gRIBI Scaling
Juniper PTX10008 status
TE-14.1: gRIBI Scaling
Nokia 7250 IXR-10e status
TE-14.1: gRIBI Scaling

Help

@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 12636765117

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12630567356: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@dplore
Copy link
Member

dplore commented Oct 31, 2024

@nflath do you plan to also update the test code to match?

* <VRF1>
* Install 9000 IPv4Entries. Each points to a NextHopGroup from E).
* <VRF2>
* Install 9000 IPv4Entries (Same IPAddress as VRF1). Each points to a NextHopGroup from F).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are using same IP address as VRF1 means , are we not planning to same destination ip as received in encapped packet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the VRF procedure - there should be different bheaviour based on the SRC ip. Let me know if this is unclear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that is correct if we directly hit VRF2 through PBF match . but if we want to validate VRF1 backup path and make sure that really dst_ip and src_ip has been updated as per encap then we need to have different prefixes in VRF2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test I don't think we want to validate the repaired path; we have more-specific tests for that.

* C) Install 200 IPv4 Entries, each pointing at a unique NHG (1:1) from B.
* D) Install 200 NextHops. Each will redirect to an IP from C).
* E) Install 100 NextHopGroups. Each will contain 2 NextHops from D). The backup next_hop_group will be to redirect to VRF2.
* F) Install 100 NextHopGroups. Each will contain 2 NextHops from D). The backup next_hop_group will be to decap and redirect to DEFAULT vrf.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are using same final NHs ( in this case it will resolve to A) then how are we planning to switch to backup path in VRF1 and validate the traffic with backup path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now this is fine; we test backup path actuation, this is to ensure the scale is proper. If we need to later, we can split B) into two groups.

@nflath
Copy link
Contributor Author

nflath commented Nov 5, 2024

@nflath do you plan to also update the test code to match?

Not in this PR. I'll. discuss who can do this work.

* B) Install 200 NextHopGroups. Each points at 8 NextHops from the first 200 entries of A) with equal weight.
* C) Install 200 IPv4 Entries, each pointing at a unique NHG (1:1) from B.
* D) Install 200 NextHops. Each will redirect to an IP from C).
* E) Install 100 NextHopGroups. Each will contain 2 NextHops from D) with weights 1:31. The backup next_hop_group will be to redirect to VRF3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to validate the weight distribution ? finally all packets goes out of same physical interface . May be it is good to have different egress interface for second half of B) NHGs and use that for second half of C) prefixes . Build E with one NH from first half D) and 1NH from second half of D).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems reasonable. Updated.

@nflath nflath requested a review from nachikethas as a code owner December 16, 2024 21:25
@nflath nflath requested a review from bkreddy143 December 16, 2024 21:25
* Install IPiniP decap-then-encap to 500 first /32 from <IPBlockVRF1>
to 500 NextHopGroups containing 1 NextHop each
* Validate that the entries are installed as FIB_PROGRAMMED
* <Default VRF>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullet format/indent seems messed up (see preview).

@nflath nflath requested a review from a team as a code owner January 3, 2025 17:49
@dplore dplore merged commit 07ae6f4 into openconfig:main Jan 6, 2025
14 checks passed
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Jan 17, 2025
* Update scaling test
* Add separation to validate traffic splits

---------

Co-authored-by: nflath <nflath@google.com>
Co-authored-by: Xiao Wang <39514181+xw-g@users.noreply.github.com>
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
* Update scaling test
* Add separation to validate traffic splits

---------

Co-authored-by: nflath <nflath@google.com>
Co-authored-by: Xiao Wang <39514181+xw-g@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants