Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RT_14.2 gribi_route_test.go #3588

Merged
merged 3 commits into from
Jan 7, 2025
Merged

RT_14.2 gribi_route_test.go #3588

merged 3 commits into from
Jan 7, 2025

Conversation

cprabha
Copy link
Contributor

@cprabha cprabha commented Nov 14, 2024

Hi,

Moving giribi client configuration code to main function.

@cprabha cprabha requested a review from a team as a code owner November 14, 2024 00:10
@OpenConfigBot
Copy link

OpenConfigBot commented Nov 14, 2024 •
edited
Loading

Pull Request Functional Test Report for #3588 / c1a172e

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-14.2: GRIBI Route Test
Cisco 8000E status
 RT-14.2: GRIBI Route Test
Cisco XRd status
 RT-14.2: GRIBI Route Test
Juniper ncPTX status
 RT-14.2: GRIBI Route Test
Nokia SR Linux status
 RT-14.2: GRIBI Route Test
Openconfig Lemming status
 RT-14.2: GRIBI Route Test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-14.2: GRIBI Route Test
Cisco 8808 status
 RT-14.2: GRIBI Route Test
Juniper PTX10008 status
 RT-14.2: GRIBI Route Test
Nokia 7250 IXR-10e status
 RT-14.2: GRIBI Route Test

Help

@coveralls
Copy link

coveralls commented Nov 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12498189326

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 12497658317: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

@Swetha-haridasula Swetha-haridasula self-assigned this Dec 24, 2024
Swetha-haridasula
Swetha-haridasula approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Swetha-haridasula Swetha-haridasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ram-mac
ram-mac approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@self-maurya self-maurya merged commit 3fa63f1 into openconfig:main Jan 7, 2025
13 of 14 checks passed
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Jan 17, 2025
@cprabha @Swetha-haridasula @ampattan
moving gribi client config to main function (openconfig#3588)
80958c2 
Co-authored-by: Swetha-haridasula <haridasula@google.com>
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
@cprabha @Swetha-haridasula @alshabib
moving gribi client config to main function (openconfig#3588)
40be018 
Co-authored-by: Swetha-haridasula <haridasula@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@self-maurya self-maurya self-maurya approved these changes

@Swetha-haridasula Swetha-haridasula Swetha-haridasula approved these changes

@ram-mac ram-mac ram-mac approved these changes

@nflath nflath Awaiting requested review from nflath

@nachikethas nachikethas Awaiting requested review from nachikethas

@xw-g xw-g Awaiting requested review from xw-g

Assignees

@Swetha-haridasula Swetha-haridasula

Labels
juniper-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cprabha @OpenConfigBot @coveralls @self-maurya @Swetha-haridasula @ram-mac