-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FP-1.1: Power admin DOWN/UP Test #3144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3144 / a1938f0Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 9708142970Details
💛 - Coveralls |
LimeHat
suggested changes
Jul 29, 2024
feature/platform/tests/power_admin_down_up_test/power_admin_down_up_test.go
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 12645595868Details
💛 - Coveralls |
LimeHat
suggested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your objective is
Empty check should be done initially before removable state check.
then you can simply rearrange the two checks in the original code. There's no need to add an extra pair of the identical checks.
feature/platform/tests/power_admin_down_up_test/power_admin_down_up_test.go
Outdated
Show resolved
Hide resolved
AmrNJ
approved these changes
Jan 7, 2025
self-maurya
approved these changes
Jan 7, 2025
af9fd68
to
a1938f0
Compare
ampattan
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Jan 17, 2025
* Added check for the fabrics which are removable * Implemented empty check correctly * updated --------- Co-authored-by: hattikals <hattikals@juniper.net>
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
* Added check for the fabrics which are removable * Implemented empty check correctly * updated --------- Co-authored-by: hattikals <hattikals@juniper.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for the fabrics which are removable