Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1.1: Power admin DOWN/UP Test #3144

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

cakhil45
Copy link
Contributor

Added check for the fabrics which are removable

@cakhil45 cakhil45 requested a review from a team as a code owner June 28, 2024 05:56
@cakhil45 cakhil45 requested a review from a team June 28, 2024 05:56
@OpenConfigBot
Copy link

OpenConfigBot commented Jun 28, 2024

Pull Request Functional Test Report for #3144 / a1938f0

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
FP-1.1: Power admin DOWN/UP Test
Cisco 8000E status
FP-1.1: Power admin DOWN/UP Test
Cisco XRd status
FP-1.1: Power admin DOWN/UP Test
Juniper ncPTX status
FP-1.1: Power admin DOWN/UP Test
Nokia SR Linux status
FP-1.1: Power admin DOWN/UP Test
Openconfig Lemming status
FP-1.1: Power admin DOWN/UP Test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
FP-1.1: Power admin DOWN/UP Test
Cisco 8808 status
FP-1.1: Power admin DOWN/UP Test
Juniper PTX10008 status
FP-1.1: Power admin DOWN/UP Test
Nokia 7250 IXR-10e status
FP-1.1: Power admin DOWN/UP Test

Help

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9708142970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%

Totals Coverage Status
Change from base Build 9707392143: 0.0%
Covered Lines: 1983
Relevant Lines: 3573

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 12645595868

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12638043326: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Copy link
Contributor

@LimeHat LimeHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your objective is
Empty check should be done initially before removable state check.
then you can simply rearrange the two checks in the original code. There's no need to add an extra pair of the identical checks.

@self-maurya self-maurya requested a review from amrindrr October 9, 2024 03:40
@AmrNJ AmrNJ assigned AmrNJ and unassigned amrindrr Jan 6, 2025
@AmrNJ AmrNJ requested a review from a team as a code owner January 6, 2025 12:04
@self-maurya self-maurya merged commit dd73085 into openconfig:main Jan 7, 2025
13 of 14 checks passed
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Jan 17, 2025
* Added check for the fabrics which are removable

* Implemented empty check correctly

* updated

---------

Co-authored-by: hattikals <hattikals@juniper.net>
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
* Added check for the fabrics which are removable

* Implemented empty check correctly

* updated

---------

Co-authored-by: hattikals <hattikals@juniper.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants