Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lalitb and ThomsonTan as approvers #355

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Add lalitb and ThomsonTan as approvers #355

merged 1 commit into from
Oct 7, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Oct 7, 2020

Discussed during the Oct. 7th, 2020 SIG meeting.

@lalitb has been actively contributing to OpenTelemetry C++ across many modules as well as general improvements to the CI and infrastructure. He is also actively driving the better design of OpenTelemetry C++ API/SDK.

PRs @lalitb has authored:

PRs @lalitb has contributed:

@ThomsonTan has been activity contributing to the overall OpenTelemetry project, including the specs, .NET client and C++ client.

PRs @ThomsonTan has authored in OpenTelemetry C++:

@ThomsonTan has also contributed to several PRs in multiple OpenTelemetry repositories, there are too many to list out here.

@reyang reyang requested a review from a team October 7, 2020 20:19
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7826040). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #355   +/-   ##
=========================================
  Coverage          ?   94.71%           
=========================================
  Files             ?      154           
  Lines             ?     6853           
  Branches          ?        0           
=========================================
  Hits              ?     6491           
  Misses            ?      362           
  Partials          ?        0           

@reyang reyang merged commit 1b2c78f into master Oct 7, 2020
@reyang reyang deleted the reyang/approvers branch October 7, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants