-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adding links to span #351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 94.98% 95.00% +0.02%
==========================================
Files 162 164 +2
Lines 6997 7086 +89
==========================================
+ Hits 6646 6732 +86
- Misses 351 354 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for diving into template metaprogramming. This looks good to me.
api/include/opentelemetry/trace/span_context_kv_iterable_view.h
Outdated
Show resolved
Hide resolved
api/include/opentelemetry/trace/span_context_kv_iterable_view.h
Outdated
Show resolved
Hide resolved
Thanks for your guidance and reviewing it. |
@reyang This should be good to merge once all the checks are completed. |
Closing old PR #342 , as this was rework. Review comments from old PR have been incorporated here.