Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding links to span #351

Merged
merged 27 commits into from
Nov 12, 2020
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 5, 2020

Closing old PR #342 , as this was rework. Review comments from old PR have been incorporated here.

@lalitb lalitb requested a review from a team October 5, 2020 11:18
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #351 (46ddd0c) into master (c504cfb) will increase coverage by 0.02%.
The diff coverage is 96.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   94.98%   95.00%   +0.02%     
==========================================
  Files         162      164       +2     
  Lines        6997     7086      +89     
==========================================
+ Hits         6646     6732      +86     
- Misses        351      354       +3     
Impacted Files Coverage Δ
api/include/opentelemetry/trace/noop.h 86.20% <ø> (ø)
sdk/include/opentelemetry/sdk/trace/tracer.h 100.00% <ø> (ø)
sdk/src/trace/span.h 100.00% <ø> (ø)
...pentelemetry/trace/span_context_kv_iterable_view.h 84.21% <84.21%> (ø)
...ude/opentelemetry/trace/span_context_kv_iterable.h 100.00% <100.00%> (ø)
api/include/opentelemetry/trace/tracer.h 100.00% <100.00%> (ø)
api/test/trace/noop_test.cc 100.00% <100.00%> (ø)
sdk/src/trace/span.cc 89.01% <100.00%> (+0.63%) ⬆️
sdk/src/trace/tracer.cc 73.52% <100.00%> (ø)
sdk/test/trace/tracer_test.cc 100.00% <100.00%> (ø)
... and 2 more

@lalitb lalitb marked this pull request as draft October 15, 2020 16:28
@lalitb lalitb marked this pull request as ready for review October 21, 2020 17:44
api/test/trace/noop_test.cc Show resolved Hide resolved
sdk/src/trace/span.cc Outdated Show resolved Hide resolved
@lalitb lalitb requested a review from pyohannes November 10, 2020 20:38
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving into template metaprogramming. This looks good to me.

sdk/src/trace/span.cc Outdated Show resolved Hide resolved
@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Nov 11, 2020
@lalitb
Copy link
Member Author

lalitb commented Nov 12, 2020

Thanks for diving into template metaprogramming. This looks good to me.

Thanks for your guidance and reviewing it.

@lalitb
Copy link
Member Author

lalitb commented Nov 12, 2020

@reyang This should be good to merge once all the checks are completed.

@reyang reyang merged commit 2bab26e into open-telemetry:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants