Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing links associated with span to Sampler #366

Closed
lalitb opened this issue Oct 16, 2020 · 0 comments · Fixed by #391
Closed

Passing links associated with span to Sampler #366

lalitb opened this issue Oct 16, 2020 · 0 comments · Fixed by #391
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lalitb
Copy link
Member

lalitb commented Oct 16, 2020 •
edited
Loading

As per the spec , collections of links associated with span need to be passed as argument to Sampler. This needs to be fixed.

This is dependent on #319
@lalitb lalitb added the bug Something isn't working label Oct 16, 2020
@pyohannes pyohannes added the good first issue Good for newcomers label Oct 22, 2020
This was referenced Nov 15, 2020
Closed
Merged
@lalitb lalitb mentioned this issue Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Passing links to sampler API lalitb/opentelemetry-cpp
Sampler links lalitb/opentelemetry-cpp
2 participants
@lalitb @pyohannes