Passing links to sampler API #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 95.00% 95.01%
=======================================
Files 164 164
Lines 7086 7099 +13
=======================================
+ Hits 6732 6745 +13
Misses 354 354
|
pyohannes
approved these changes
Nov 16, 2020
| @@ -70,7 +71,8 @@ class Sampler | |||
| trace_api::TraceId trace_id, | |||
| nostd::string_view name, | |||
| trace_api::SpanKind span_kind, | |||
| const opentelemetry::common::KeyValueIterable &attributes) noexcept = 0; | |||
| const opentelemetry::common::KeyValueIterable &attributes, | |||
| const trace_api::SpanContextKeyValueIterable &links) noexcept = 0; | |||
There was a problem hiding this comment.
The TODO on line 64 can be removed.
ThomsonTan
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #366