Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit type conversion to narrower data type #347

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

ThomsonTan
Copy link
Contributor

Add explicit type conversion and more fixes to consistency of using size_t and int.

@ThomsonTan ThomsonTan requested a review from a team September 30, 2020 18:23
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #347 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         154      154           
  Lines        6847     6853    +6     
=======================================
+ Hits         6485     6491    +6     
  Misses        362      362           
Impacted Files Coverage Δ
ext/test/zpages/tracez_data_aggregator_test.cc 97.34% <ø> (ø)
...lemetry/sdk/metrics/aggregator/sketch_aggregator.h 69.76% <100.00%> (ø)
sdk/test/trace/probability_sampler_test.cc 100.00% <100.00%> (ø)

@reyang reyang merged commit cbcc63e into open-telemetry:master Oct 5, 2020
@ThomsonTan ThomsonTan deleted the FixMoreTypes branch November 9, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants