Change type of Resize capacity from int to size_t #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter
new_capacity
forRuntimeContext::Resize()
should be in typesize_t
instead ofint
, to be consistent withsize_
.This could cause issue because
size_t
could have larger range thanint
(this is the case on Windows 64-bit system which is in LLP64 data model), so convertsize_t
toint
could cause data loss.