Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include folders for example OTLP exporter #300

Closed

Conversation

ThomsonTan
Copy link
Contributor

Added missing included folders and also renamed library target foo_library to otlp_foo_library in CMakeLists.txt. The name foo_library conflicts with the library in simple example.

gRPC dependency is still missing so I didn't add this exporter to the parent CMakeLists.txt, will fix it later.

@ThomsonTan ThomsonTan requested a review from a team August 26, 2020 17:55
@linux-foundation-easycla
Copy link

CLA Check

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         146      146           
  Lines        6610     6610           
=======================================
  Hits         6250     6250           
  Misses        360      360           

@ThomsonTan
Copy link
Contributor Author

Will fix user Id and resend this PR.

@ThomsonTan ThomsonTan closed this Aug 26, 2020
@ThomsonTan ThomsonTan deleted the FixExampleOtlpExporter branch November 9, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant